Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd minimum version for typeguard to fix a MonitoringHub bug #1419
Conversation
With typeguard 2.3, loading parsl.monitoring.monitoring issues
this warning:
```
>>> import parsl.monitoring.monitoring
/home/benc/parsl/virtualenv-3.7/lib/python3.7/site-packages/typeguard.py:505: UserWarning: no type annotations present -- not typechecking parsl.monitoring.monitoring.MonitoringHub
warn('no type annotations present -- not typechecking {}'.format(function_name(func)))
```
This commit forces a newer version which works.
requirements.txt
Outdated
| psutil>=5.5.1 |
This comment has been minimized.
This comment has been minimized.
ZhuozhaoLi
Oct 30, 2019
Contributor
Not sure why it shows there is a change on psutil (but cannot tell any difference).
This comment has been minimized.
This comment has been minimized.
benclifford
Oct 30, 2019
Author
Contributor
it's an addition/removal of a newline at the end of file from my editor
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
benclifford commentedOct 30, 2019
With typeguard 2.3, loading parsl.monitoring.monitoring issues
this warning:
This commit forces a newer version which works.