Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPatch to fix #870 and add the chemical structure info as a separate table #950
+44
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
This works for me, but there is an odd side effect that the "Recently published works on the chemical" panel does not seem to get displayed anymore (I tried multiple times). I don't see how your code could have caused that, so it might just be some caching issue. In any case, I'm attaching screenshots for your proposed PR (top) and the current situation (bottom), both for https://tools.wmflabs.org/scholia/chemical/Q2270 (benzene). I also checked https://tools.wmflabs.org/scholia/chemical/Q159683 (citric acid), with the same result.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
egonw commentedNov 29, 2019
This solves the problem that the SMILES and InChI were messing up the layout of the identifier table (with the value column way too wide).