Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create berlin-school-of-economics-and-law-international-marketing-man… #3774

Merged
merged 7 commits into from Dec 18, 2019

Conversation

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2018

😃 Your submission passed all our automated tests.

…agement.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2018

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Two quick comments/questions, rest looks good, thanks!

</macro>
<macro name="page-range">
<group delimiter=" ">
<text term="page" form="short"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 9, 2018

Member

You don't want label variable="page" here so it becomes p./pp. contextually?

</macro>
<macro name="creator-short">
<names variable="author">
<name form="short" delimiter="/"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 9, 2018

Member

I'm guessing you'll want delimiter-precedes-last="always" here? I don't think this would otherwise draw a / between two authors.

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Nov 9, 2018

Author Contributor

thanks for spotting those.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 9, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 10, 2018

(don't merge: this still needs editors fixed as per forums)

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Nov 12, 2018

@POBrien333, could you also attach a copy of the style guide to this pull request? The current "documentation" link seems to point to a file-sharing website (with a free tier that deletes files 60 days after the last download).

…agement.csl
@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Nov 12, 2018

@rmzelle
Uploaded to this PR. Wasn't able to find it anywhere online.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 12, 2018

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Nov 13, 2018

(looks good to merge once the editor issue has been addressed)

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Nov 13, 2018

No clue how to fix that, I'm afraid.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 13, 2018

I'll take a look. It's a weird requirement that I'm not sure we can meet 100%.

@adam3smith adam3smith self-assigned this Dec 5, 2018
@stale

This comment has been minimized.

Copy link

stale bot commented Jan 4, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Jan 4, 2019
@stale stale bot closed this Jan 18, 2019
@adam3smith adam3smith reopened this Jan 18, 2019
@stale stale bot removed the waiting label Jan 18, 2019
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 18, 2019

Still looking at this, but it's a bit weird

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 18, 2019

😃 Your submission passed all our automated tests.

@stale

This comment has been minimized.

Copy link

stale bot commented Feb 17, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Feb 17, 2019
@stale stale bot closed this Mar 3, 2019
@adam3smith adam3smith added the pinned label Mar 4, 2019
@adam3smith adam3smith reopened this Mar 4, 2019
@stale stale bot removed the waiting label Mar 4, 2019
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 4, 2019

OK, stalebot, I get it, it's taking too long, but I promise it's still on my list.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 4, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

berlin-school-of-economics-and-law-international-marketing-management.csl (new)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012), in: (2012), Citation Style Editor, online at URL: http://editor.citationstyles.org/searchByExample/ (15 December 2012)
Fenner, M./Crosas, M./Grethe, J. S./Kennedy, D./Hermjakob, H./Rocca-Serra, P./Durand, G./Berjon, R./Karcher, S./Martone, M./Clark, T. (2019), A data citation roadmap for scholarly data repositories, in: Scientific Data, 6th volume, 1/2019, p. 28
Hancké, B./Rhodes, M./Thatcher, M. (2007, Ed.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York
Mares, I. (2001), Firms and the welfare state: When, why, and how does social policy matter to employers?, in: Hall, P. A./Soskice, D., (2001, Ed.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, 2001, p. 184–213
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😟 There are some issues with your submission.

1 test failed

berlin-school-of-economics-and-law-international-marketing-management: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit eab02ea into citation-style-language:master Dec 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Dec 18, 2019

So that took a while...

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Dec 18, 2019

haha. This is funny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.