Create jurnal-sains-farmasi-dan-klinis.csl #4455

yoriyuliandra · 2019-12-17T12:05:45Z

Hello. This is the first time submission/request to store the csl of our journal. Thanks


        Create jurnal-sains-farmasi-dan-klinis.cls

csl-bot · 2019-12-17T12:05:55Z

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot · 2019-12-17T12:09:56Z

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/dependent/jurnal-sains-farmasi-dan-klinis.cls"]

(compared using ==)

Please check the test report for details.


        Rename jurnal-sains-farmasi-dan-klinis.cls to jurnal-sains-farmasi-da…

…n-klinis.csl the extension has been changed from cls to csl

csl-bot · 2019-12-17T12:21:16Z

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/dependent/jurnal-sains-farmasi-dan-klinis.cls"]

(compared using ==)

Please check the test report for details.

csl-bot · 2019-12-17T12:25:15Z

😟 There are some issues with your submission.

4 tests failed

dependent/jurnal-sains-farmasi-dan-klinis: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" page-range-format="minimal" demote-non-dropping-particle="sort-only" children=[5]>.dependent?` to return true, got nil

dependent/jurnal-sains-farmasi-dan-klinis: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/jurnal-sains-farmasi-dan-klinis: may not have <macro/>, <citation/>, or <bibliography/> elements

expected #has_macro? to return false, got true

dependent/jurnal-sains-farmasi-dan-klinis: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

Please check the test report for details.


        Fix validation

adam3smith · 2019-12-17T15:12:54Z

Thanks! Just to clarify -- the style differs from the various Vancouver styles we already offer?
And it looks like this is based on an existing style -- was that just vancouver.csl or something else?

csl-bot · 2019-12-17T15:16:20Z

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

jurnal-sains-farmasi-dan-klinis.csl (new)

[1,2]
[3,4]

[1]. Hancké B, Rhodes M, Thatcher M, editors. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press; 2007.
[2]. CSL search by example [Internet]. Citation Style Editor. 2012 [cited 2012Dec15]. Available from: http://editor.citationstyles.org/searchByExample/
[3]. Mares I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA, Soskice D, editors. Varieties of capitalism The institutional foundations of comparative advantage. New York: Oxford University Press; 2001. p. 184–213.
[4]. Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, et al. A data citation roadmap for scholarly data repositories. Scientific Data. 2019;6(1):28. https://doi.org/10.1038/s41597-019-0031-8

yoriyuliandra · 2019-12-18T00:41:01Z

Thanks! Just to clarify -- the style differs from the various Vancouver styles we already offer?
And it looks like this is based on an existing style -- was that just vancouver.csl or something else?

Hi, yes it's basically taken from Vancouver. But I modified a couple of things to suit our journal guidelines. So, this is something different. Thanks


        Update jurnal-sains-farmasi-dan-klinis.csl

csl-bot · 2019-12-18T01:44:14Z

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

jurnal-sains-farmasi-dan-klinis.csl (new)

[1,2]
[3,4]

[1]. Hancké B, Rhodes M, Thatcher M, editors. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press; 2007.
[2]. CSL search by example [Internet]. Citation Style Editor. 2012 [cited 2012Dec15]. Available from: http://editor.citationstyles.org/searchByExample/
[3]. Mares I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA, Soskice D, editors. Varieties of capitalism The institutional foundations of comparative advantage. New York: Oxford University Press; 2001. p. 184–213.
[4]. Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, et al. A data citation roadmap for scholarly data repositories. Scientific Data. 2019;6(1):28. https://doi.org/10.1038/s41597-019-0031-8

adam3smith · 2019-12-18T01:49:00Z

Great, thanks!

yoriyuliandra · 2019-12-18T01:51:16Z

[4]. Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, et al. A data citation roadmap for scholarly data repositories. Scientific Data. 2019;6(1):28. https://doi.org/10.1038/s41597-019-0031-8

Looks good. But I was hoping the journal title in the citation number 4 to be abbreviated (Sci Data instead of Scientific Data). So, it would be:

[4]. Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, et al. A data citation roadmap for scholarly data repositories. Sci Data. 2019;6(1):28. https://doi.org/10.1038/s41597-019-0031-8

adam3smith · 2019-12-18T02:01:45Z

Yeah, the style does that, the abbreviation is just not in the metadata used for the test.

yoriyuliandra · 2019-12-18T02:20:19Z

Cool. Thanks

Create jurnal-sains-farmasi-dan-klinis.cls

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

e16ffa5

yoriyuliandra changed the title ~~Create jurnal-sains-farmasi-dan-klinis.cls~~ Create jurnal-sains-farmasi-dan-klinis.csl Dec 17, 2019

yoriyuliandra closed this Dec 17, 2019

yoriyuliandra reopened this Dec 17, 2019

Fix validation

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

ec5c67e

Update jurnal-sains-farmasi-dan-klinis.csl

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

4920abf

adam3smith merged commit 3ad4260 into citation-style-language:master Dec 18, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Please note that GitHub no longer supports your web browser.

citation-style-language/styles

Create jurnal-sains-farmasi-dan-klinis.csl #4455

Create jurnal-sains-farmasi-dan-klinis.csl #4455

yoriyuliandra commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

adam3smith commented Dec 17, 2019 •

edited

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

This comment has been minimized.

csl-bot commented Dec 18, 2019

This comment has been minimized.

adam3smith commented Dec 18, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

This comment has been minimized.

adam3smith commented Dec 18, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

Please note that GitHub no longer supports your web browser.

citation-style-language/styles

Join GitHub today

Create jurnal-sains-farmasi-dan-klinis.csl #4455

Create jurnal-sains-farmasi-dan-klinis.csl #4455

Conversation

yoriyuliandra commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

adam3smith commented Dec 17, 2019 • edited

This comment has been minimized.

csl-bot commented Dec 17, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

This comment has been minimized.

csl-bot commented Dec 18, 2019

This comment has been minimized.

adam3smith commented Dec 18, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

This comment has been minimized.

adam3smith commented Dec 18, 2019

This comment has been minimized.

yoriyuliandra commented Dec 18, 2019

adam3smith commented Dec 17, 2019 •

edited