Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create romanian-iso-690-full-note-with-ibid-romanian.csl #4465

Merged
merged 8 commits into from Dec 21, 2019

Conversation

@mihaiconstantinescu
Copy link
Contributor

mihaiconstantinescu commented Dec 18, 2019

This style is based on the Inventaire général du patrimoine culturel - ISO-690 (full note, with Ibid., French) style and has been developed in order to fulfill the needs of the Romanian academic community.
I've made several changes to adjust the needs of the Romanian community (using the terms vol and nr in the print version instead of just the numbers for example, changing terms according to the Romanian version etc)

This style is based on the Inventaire général du patrimoine culturel - ISO-690 (full note, with Ibid., French) style and has been developed in order to fulfill the needs of the Romanian academic community
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 18, 2019

😟 There are some issues with your submission.

1 test failed

Romanian ISO-690 (full note, with Ibid., Romanian): must have a conventional file name

expected "Romanian ISO-690 (full note, with Ibid., Romanian).csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Romanian ISO-690 (full note, with Ibid., Romanian).csl"

Please check the test report for details.

@mihaiconstantinescu mihaiconstantinescu changed the title Create Romanian ISO-690 (full note, with Ibid., Romanian).csl Create romanian ISO-690(full-note, with-ibid., romanian).csl Dec 19, 2019
@mihaiconstantinescu mihaiconstantinescu changed the title Create romanian ISO-690(full-note, with-ibid., romanian).csl Create Romanian ISO-690 (full-note, with-ibid., Romanian).csl Dec 19, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 19, 2019

😟 There are some issues with your submission.

2 tests failed

Romanian ISO-690 (full note, with Ibid., Romanian): must have a conventional file name

expected "Romanian ISO-690 (full note, with Ibid., Romanian).csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Romanian ISO-690 (full note, with Ibid., Romanian).csl"

Romanian ISO-690 (full note, with Ibid., Romanian): style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/Romanian ISO-690 (full note, with Ibid., Romanian)"
     got: "http://www.zotero.org/styles/romanian-iso-690-full-note-with-ibid-romanian"

(compared using ==)

Please check the test report for details.

@mihaiconstantinescu mihaiconstantinescu changed the title Create Romanian ISO-690 (full-note, with-ibid., Romanian).csl Create romanian-iso-690-full-note-with-ibid-romanian.csl Dec 19, 2019
…nian-iso-690-full-note-with-ibid-romanian.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 19, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

romanian-iso-690-full-note-with-ibid-romanian.csl (new)
HANCKÉ, Bob, RHODES, Martin și THATCHER, Mark (ed.). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press, 2007. ISBN 978-0-19-920648-3 ; CSL search by example. În: Citation Style Editor [on-line]. 2012 [accesat la 15 decembrie 2012]. Disponibil la: http://editor.citationstyles.org/searchByExample/.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? În: HALL, Peter A. și SOSKICE, David (ed.), Varieties of capitalism. The institutional foundations of comparative advantage. New York : Oxford University Press, 2001, p. 184-213 ; FENNER, Martin, CROSAS, Mercè, GRETHE, Jeffrey S., et al. A data citation roadmap for scholarly data repositories. Scientific Data [on-line]. 10 aprilie 2019 [accesat la 27 aprilie 2019], Vol. 6, nr. 1, p. 28. DOI 10.1038/s41597-019-0031-8.

CSL search by example. În: Citation Style Editor [on-line]. 2012 [accesat la 15 decembrie 2012]. Disponibil la: http://editor.citationstyles.org/searchByExample/.
FENNER, Martin et al. A data citation roadmap for scholarly data repositories. Scientific Data [on-line]. 10 aprilie 2019 [accesat la 27 aprilie 2019], Vol. 6, nr. 1, p. 28. DOI 10.1038/s41597-019-0031-8.
HANCKÉ, Bob, RHODES, Martin și THATCHER, Mark (ed.). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press, 2007. ISBN 978-0-19-920648-3.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? În: HALL, Peter A. și SOSKICE, David (ed.), Varieties of capitalism. The institutional foundations of comparative advantage. New York : Oxford University Press, 2001, p. 184-213.
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Dec 20, 2019

Thanks! Is the Romanian part of this documented somewhere?

@mihaiconstantinescu

This comment has been minimized.

Copy link
Contributor Author

mihaiconstantinescu commented Dec 20, 2019

Thanks! Is the Romanian part of this documented somewhere?

I'm not really sure what you mean by „documented somewhere” (I'm new to github and csl, srry). Do u mean if I created a document showing the translations that I used? if that, the answer is no but I want to (as soon as I can).

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Dec 20, 2019

Do u mean if I created a document showing the translations that I used?

Basically, yes. You mention some other change like "using the terms vol and nr in the print version instead of just the numbers for example" -- we would very much like documentation these changes are based on so we have a point of reference e.g. if someone complains about (what they think is) an error in a style.

…o iso690-full-note-with-ibid-ro.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 20, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 20, 2019

😃 Your submission passed all our automated tests.

@mihaiconstantinescu

This comment has been minimized.

Copy link
Contributor Author

mihaiconstantinescu commented Dec 20, 2019

Do u mean if I created a document showing the translations that I used?

Basically, yes. You mention some other change like "using the terms vol and nr in the print version instead of just the numbers for example" -- we would very much like documentation these changes are based on so we have a point of reference e.g. if someone complains about (what they think is) an error in a style.

ok. I understand. Will upload a document detailing these changes in 24 hr or less.

@mihaiconstantinescu

This comment has been minimized.

Copy link
Contributor Author

mihaiconstantinescu commented Dec 21, 2019

Do u mean if I created a document showing the translations that I used?

Basically, yes. You mention some other change like "using the terms vol and nr in the print version instead of just the numbers for example" -- we would very much like documentation these changes are based on so we have a point of reference e.g. if someone complains about (what they think is) an error in a style.

I'm not sure where I should upload this document (and how this document should be structured or written) so I uploaded it here.
hope everything is ok.
changes for the Romanian ISO 690.docx

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 21, 2019

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 8797c01 into citation-style-language:master Dec 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Dec 21, 2019

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.