Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chicago Manual Presentation issues #3243

Closed
adam3smith opened this issue Jan 4, 2018 · 9 comments · Fixed by #4358
Closed

Chicago Manual Presentation issues #3243

adam3smith opened this issue Jan 4, 2018 · 9 comments · Fixed by #4358
Assignees

Comments

@adam3smith adam3smith self-assigned this Jan 4, 2018
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Dec 27, 2018

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Dec 27, 2018
@njbart

This comment has been minimized.

Copy link
Contributor

@njbart njbart commented Jan 4, 2019

@adam3smith – In jgm/pandoc-citeproc#45 (comment) you said, “Chicago has so many moving parts that it always takes a bit longer to fix, but shouldn't be too hard here.” – Your work’s much appreciated, and I have no complaints at all about having to wait some time …

… but I do have my doubts whether the new stale bot indiscriminately closing issues after 30 days of inactivity is such a good idea – it seems to kind of defeat the actual purpose of an issue tracker.

@stale stale bot removed the waiting label Jan 4, 2019
@rmzelle

This comment has been minimized.

Copy link
Member

@rmzelle rmzelle commented Jan 5, 2019

but I do have my doubts whether the new stale bot indiscriminately closing issues after 30 days of inactivity is such a good idea – it seems to kind of defeat the actual purpose of an issue tracker.

We can exempt certain tickets from being automatically closed.

We added the bot to help us manage tickets for style submissions. The volume of these tickets is quite high, and we don't always have the time to respond right away. We also often have to wait to hear back from the contributors.

Hopefully the bot will help us in responding more timely to such tickets, while automating the process of style submission tickets that need to be closed because the contributor doesn't provide all the necessary information we need to accept a style.

Any suggestions to improve our workflow are always welcome, though.

@rmzelle rmzelle added the pinned label Jan 5, 2019
adam3smith added a commit that referenced this issue Oct 15, 2019
Fixes #3756
Fixes #3243
Fixes duplicate dates in map and artwork: 
https://forums.zotero.org/discussion/69887/date-in-cms-map-citation#latest
Extends uncertain date to all 17th edition Chicago styles
adam3smith added a commit that referenced this issue Oct 15, 2019
Fixes #3756
Fixes #3243
Fixes duplicate dates in map and artwork: 
https://forums.zotero.org/discussion/69887/date-in-cms-map-citation#latest
Extends uncertain date to all 17th edition Chicago styles
@njbart

This comment has been minimized.

Copy link
Contributor

@njbart njbart commented Oct 16, 2019

Great this is being dealt with. However, it seems that with the latest fixes to chicago-fullnote-bibliography.csl, event and event-place are omitted from the notes (they used to be included previously; see jgm/pandoc-citeproc#45 (comment)).

CMOS (17e, 14.217) quite clearly does call for including this information in notes:

  1. David G. Harper, “The Several Discoveries of the Ciliary Muscle” (Power­Point presentation, 25th Anniversary of the Cogan Ophthalmic History Society, Bethesda, MD, March 31,2012).
  1. Viviana Hong, “Censorship in Children’s Literature during Argentina’s Dirty War (1976-1983)” (lecture, University of Chicago, Chicago, IL, April 30, 2015).

pandoc example (same as in jgm/pandoc-citeproc#45 (comment)):

pandoc -s -F pandoc-citeproc -t plain <<EOT

Foo [@item1]. Bar [@item2].

# References {-}

---
csl: chicago-fullnote-bibliography.csl
references:
- title-short: Early violent death in delinquent youth
  author:
  - family: Teplin
    given: Linda A.
  - family: McClelland
    given: Gary M.
  - family: Abram
    given: Karen M.
  - family: Washburn
    given: Jason J.
  id: item2
  issued:
    date-parts:
    - - 2005
      - 3
  title: 'Early violent death in delinquent youth: A prospective longitudinal study'
  type: speech
  genre: paper
  event: Annual Meeting of the American Psychology-Law Society
  event-place: La Jolla, CA

- author:
  - family: "D’Erasmo"
    given: Stacy
  id: item1
  issued:
    date-parts:
    - - 2000
      - 4
      - 26
  title: The craft and career of writing
  type: speech
  genre: lecture
  event-place: Northwestern University, Evanston, IL
...
EOT

Actual output (with the latest chicago-fullnote-bibliography.csl):

Foo.[1] Bar.[2]

References

D’Erasmo, Stacy. “The Craft and Career of Writing.” Lecture,
Northwestern University, Evanston, IL, April 26, 2000.

Teplin, Linda A., Gary M. McClelland, Karen M. Abram, and Jason J.
Washburn. “Early Violent Death in Delinquent Youth: A Prospective
Longitudinal Study.” Paper presented at the Annual Meeting of the
American Psychology-Law Society, La Jolla, CA, March 2005.

[1] Stacy D’Erasmo, “The Craft and Career of Writing” (lecture, April
26, 2000).

[2] Linda A. Teplin et al., “Early Violent Death in Delinquent Youth: A
Prospective Longitudinal Study” (paper, March 2005).

Expected output (just the notes):

[^1]: Stacy D’Erasmo, “The Craft and Career of Writing” (lecture,
    Northwestern University, Evanston, IL, April 26, 2000).

[^2]: Linda A. Teplin et al., “Early Violent Death in Delinquent Youth:
    A Prospective Longitudinal Study” (paper presented at the Annual
    Meeting of the American Psychology-Law Society, La Jolla, CA, March
    2005).
@adam3smith

This comment has been minimized.

Copy link
Member Author

@adam3smith adam3smith commented Oct 16, 2019

@njbart Thanks -- yes, that's not right. Could you take a look at and do some tests on your end on this version:
https://gist.github.com/adam3smith/e57176585063ebdd822ebf414bc86965

@njbart

This comment has been minimized.

Copy link
Contributor

@njbart njbart commented Oct 17, 2019

The pandoc example output looks like this now:

Foo.[1] Bar.[2]

References

D’Erasmo, Stacy. “The Craft and Career of Writing.” Lecture,
Northwestern University, Evanston, IL, April 26, 2000.

Teplin, Linda A., Gary M. McClelland, Karen M. Abram, and Jason J.
Washburn. “Early Violent Death in Delinquent Youth: A Prospective
Longitudinal Study.” Paper presented at the Annual Meeting of the
American Psychology-Law Society, La Jolla, CA, March 2005.

[1] Stacy D’Erasmo, “The Craft and Career of Writing” (lecture,
Northwestern University, Evanston, IL, April 26, 2000).

[2] Linda A. Teplin et al., “Early Violent Death in Delinquent Youth: A
Prospective Longitudinal Study” (paper, Annual Meeting of the American
Psychology-Law Society, La Jolla, CA, March 2005).

So, event-place and event, if present, appear.

I noticed that “presented at the” is no longer inserted in items inside notes (though it is in bibliography items). Given that this string it isn’t actually ever used in items in notes by CMOS itself (16e and 17e), that’s acceptable, I guess.

I’ll run a few other tests; if I spot anything unusual, I’ll let you know.

@njbart

This comment has been minimized.

Copy link
Contributor

@njbart njbart commented Oct 17, 2019

Is there any reason why the chicago styles use number variable="issue" whereas many others (in fact, all others out of the 61 styles that happen to sit in my ~/Zotero/styles folder, with the exception of ieee.csl) use text variable="issue"?

The reason I’m asking: When using footnote styles with number variable="issue", pandoc(-citeproc) incorrectly renders issue fields that happen to contain an en-dash (e.g.,1–2) with added spaces as 1 – 2. (I haven’t observed any of this with Zotero/LO.)

The extra spaces disappear when using, e.g., a patched chicago-fullnote-bibliography.csl which uses text variable="issue".

Of course, the best solution will be to get pandoc itself fixed (I’ll file a bug report at the pandoc issue tracker soonish).

As to the csl side, at the moment I’m just curious whether there’s any reason to prefer one or the other.

@adam3smith

This comment has been minimized.

Copy link
Member Author

@adam3smith adam3smith commented Oct 18, 2019

I don't think there is -- I suspect this goes back to @fbennett 's original coding of the style and may well have just been a generic preference by him at a time when we were all still figuring out how CSL 1.0 was going to work best -- git blame shows the last change to the number variable lines to be reindenting by Rintze 7 years ago... The only reasons to use number variable is to remove non-numeric content and/or to take advantage of number formatting like ordinal or roman. Neither is the case here. I'll switch this for everything except edition.

@adam3smith adam3smith reopened this Jan 12, 2020
adam3smith added a commit that referenced this issue Jan 12, 2020
- add chicago-fullnote-short-title-subsequent, which behaves like the 
16th ed. no-ibid style, printing short titles on all subsequent 
citations, including in ibid position
- remove all `number variable` calls on issue and volume unless they 
specifically reference number properties (see #3243)
- Fix the issue with event and event place for presentations noted in 
#3243
@adam3smith

This comment has been minimized.

Copy link
Member Author

@adam3smith adam3smith commented Jan 14, 2020

OK both remaining issues mentioned by @njbart -- the event/event-place and the number variables -- are fixed in 176df5f

@adam3smith adam3smith closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.