Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CONTRIBUTING.md and .github/PULL_REQUEST_TEMPLATE.md #174
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your locale file validates. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
koppor
referenced this pull request
Jan 18, 2018
Merged
Add translators from git log to the locale files. #173
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
This comment has been minimized.
This comment has been minimized.
@adam3smith Does this also look OK for you? |
This comment has been minimized.
This comment has been minimized.
I'll rewrite this a little bit before merging, and it might be a few days before I have time to do so, but generally this looks good to me. |
This comment has been minimized.
This comment has been minimized.
Yes, I think we should add to the checklist (formatting and validation at least) but generally I have no objections. @rmzelle feel free to merge when you´re done editing |
This comment has been minimized.
This comment has been minimized.
ping @rmzelle -- I think this would be nice to have |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 23, 2019
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
rmzelle
requested a review
from
adam3smith
Jan 23, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 23, 2019
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
This comment has been minimized.
This comment has been minimized.
a few days Anyway, @adam3smith, let me know if you like it like this. Also, in the many years since we moved to GitHub, I feel that the GitHub wikis have mostly been replaced by README.md and other repository files for the purpose of providing information to users and contributors. It probably makes sense for us to make README.md the starting point for linking to the various sources of documentation (here and in the other main CSL repos). |
This comment has been minimized.
This comment has been minimized.
Good to merge from my end -- thanks! |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 23, 2019
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
This comment has been minimized.
This comment has been minimized.
(and do you agree on the wiki sentiment? I think the big advantage of in-repo files is that we get all the benefits of the regular GitHub code workflow, whereas wikis are either locked down or open-to-all) |
rmzelle
merged commit 6ccf164
into
citation-style-language:master
Jan 23, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks both! |
koppor commentedJan 18, 2018
This adds initial contribution guidelines. This refs #173 and should ensure that future updates come with a complete list of translators.