New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates locates uk-UA.xml #181

Merged
merged 4 commits into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@vkochyn
Contributor

vkochyn commented Sep 17, 2018

Updates according to DSTU 8302:2015 for Ukrainian.

Updates locates uk-UA.xml
Updates according to DSTU 8302:2015 for Ukrainian.
@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Sep 17, 2018

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented Sep 17, 2018

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Sep 17, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Sep 17, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle

@vkochyn, a few questions, but generally this looks like a big improvement.

Show outdated Hide outdated locales-uk-UA.xml
Show outdated Hide outdated locales-uk-UA.xml
Show outdated Hide outdated locales-uk-UA.xml
@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 19, 2018

Contributor
Contributor

vkochyn commented Sep 19, 2018

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Sep 19, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Sep 19, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Sep 19, 2018

Member

2nd should be i such way:
<term name="circa" form="short">бл</term>

Should that be <term name="circa" form="short">бл.</term> (with a period)?

Member

rmzelle commented Sep 19, 2018

2nd should be i such way:
<term name="circa" form="short">бл</term>

Should that be <term name="circa" form="short">бл.</term> (with a period)?

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 19, 2018

Contributor
Contributor

vkochyn commented Sep 19, 2018

Show outdated Hide outdated locales-uk-UA.xml
Show outdated Hide outdated locales-uk-UA.xml
Show outdated Hide outdated locales-uk-UA.xml
@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 21, 2018

Contributor
Contributor

vkochyn commented Sep 21, 2018

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 21, 2018

Contributor
Contributor

vkochyn commented Sep 21, 2018

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 21, 2018

Contributor
Contributor

vkochyn commented Sep 21, 2018

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Sep 23, 2018

Member

There is no short form for references. More using is список використаних джерел and some uses примітки. So It is possible to use only long form with out short it will be more correct than just alternative vercions.

So you can't come up with an abbreviated version of "список використаних джерел"?

CSL locale files only allow a single translation of each term for each form. If multiple translations are in use, we just use the most common one (individual CSL styles can always override the translations from the CSL locale files).

Member

rmzelle commented Sep 23, 2018

There is no short form for references. More using is список використаних джерел and some uses примітки. So It is possible to use only long form with out short it will be more correct than just alternative vercions.

So you can't come up with an abbreviated version of "список використаних джерел"?

CSL locale files only allow a single translation of each term for each form. If multiple translations are in use, we just use the most common one (individual CSL styles can always override the translations from the CSL locale files).

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Sep 23, 2018

Member

All terms should be without points

Sorry, can you clarify? I'm a bit confused. Does Ukrainian never use periods for abbreviations? The abbreviate translations you supplied do use periods (e.g. <term name="book" form="short">кн.</term>).

Member

rmzelle commented Sep 23, 2018

All terms should be without points

Sorry, can you clarify? I'm a bit confused. Does Ukrainian never use periods for abbreviations? The abbreviate translations you supplied do use periods (e.g. <term name="book" form="short">кн.</term>).

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Sep 23, 2018

Member

OK. But it wouldn`t be using. I just put long and short forms near by and I've deleted points. I hope it will be clear + ------ режисер ---- реж

Again, I'm not sure I fully understand you. What do you mean with "But it wouldn`t be using." here? (Feel free to write back in Ukrainian. Google Translate is very good nowadays)

My question was about the short role forms (e.g. <term name="director">реж.</term>), which should have been written as <term name="director" form="short">реж.</term>.

Member

rmzelle commented Sep 23, 2018

OK. But it wouldn`t be using. I just put long and short forms near by and I've deleted points. I hope it will be clear + ------ режисер ---- реж

Again, I'm not sure I fully understand you. What do you mean with "But it wouldn`t be using." here? (Feel free to write back in Ukrainian. Google Translate is very good nowadays)

My question was about the short role forms (e.g. <term name="director">реж.</term>), which should have been written as <term name="director" form="short">реж.</term>.

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Sep 23, 2018

Member

(in general, it's also easier if you respond via the GitHub website instead of via email)

Member

rmzelle commented Sep 23, 2018

(in general, it's also easier if you respond via the GitHub website instead of via email)

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 23, 2018

Contributor
Contributor

vkochyn commented Sep 23, 2018

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 23, 2018

Contributor
Contributor

vkochyn commented Sep 23, 2018

@vkochyn

This comment has been minimized.

Show comment
Hide comment
@vkochyn

vkochyn Sep 23, 2018

Contributor
Contributor

vkochyn commented Sep 23, 2018

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Sep 25, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Sep 25, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Sep 25, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Sep 25, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@adam3smith adam3smith merged commit 29ed2ff into citation-style-language:master Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Sep 26, 2018

Member

Great, thanks!

Member

adam3smith commented Sep 26, 2018

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment