Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new style to create @ sciences po #4486

Merged

Conversation

@AnnaCouthuresIdrizi
Copy link
Contributor

AnnaCouthuresIdrizi commented Jan 3, 2020

Sciences Po - Ecole doctorale (note, French)

Sciences Po - Ecole doctorale (note, French)
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 3, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 3, 2020

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/sciences-po-ecole-doctorale-note-french"]

(compared using ==)

Please check the test report for details.

…octorale-note-french.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 3, 2020

😟 There are some issues with your submission.

1 test failed

sciences-po-ecole-doctorale-note-french: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/sciences-po-ecole-doctorale-note-french"
     got: "http://www.zotero.org/styles/sciences-po-ecole-doctorale-note"

(compared using ==)

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 6, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

sciences-po-ecole-doctorale-note-french.csl (new)
Hancké, Bob, Martin Rhodes, et Mark Thatcher (eds.). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York : : Oxford University Press, 2007.  ; CSL search by example. 2012. En ligne : http://editor.citationstyles.org/searchByExample/ [consulté le 15 décembre 2012].
Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » in Peter A. Hall et David Soskice (eds.). Varieties of capitalism. The institutional foundations of comparative advantage. New York : : Oxford University Press, 2001, p.184‑213.  ; Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, et al. « A data citation roadmap for scholarly data repositories », Scientific Data. 10 avril 2019, vol.6 nᵒ 1. p.28. En ligne : http://www.nature.com/articles/s41597-019-0031-8 [consulté le 27 avril 2019].

CSL search by example.2012.En ligne : http://editor.citationstyles.org/searchByExample/ [consulté le 15 décembre 2012].
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, et al.« A data citation roadmap for scholarly data repositories », Scientific Data.10 avril 2019, vol.6 nᵒ 1.p.28.En ligne : http://www.nature.com/articles/s41597-019-0031-8 [consulté le 27 avril 2019].
Hancké, Bob, Martin Rhodes, et Mark Thatcher (eds.).Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy.Oxford and New York : .Oxford University Press.2007.
Mares, Isabela.« Firms and the welfare state: When, why, and how does social policy matter to employers? » in Peter A. Hall et David Soskice (eds.). Varieties of capitalism. The institutional foundations of comparative advantage.New York : .Oxford University Press.2001, p.184‑213.
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 12, 2020

@adam3smith, do you have time to review this? See also #3868 (review) which auto-closed.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 14, 2020

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Thanks -- this looks good, just two quick questions/suggestions.

sciences-po-ecole-doctorale-note-french.csl Outdated Show resolved Hide resolved
sciences-po-ecole-doctorale-note-french.csl Outdated Show resolved Hide resolved
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 15, 2020

😟 There are some issues with your submission.

1 test failed

sciences-po-ecole-doctorale-note-french: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "170:55: FATAL: xmlParseEntityRef: no name"]].empty?` to return true, got false

Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 15, 2020

Sorry, that was my bad. nbsp is   not &160; Fixed that, everything else looks good.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 15, 2020

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit f80b38c into citation-style-language:master Jan 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 15, 2020

Thanks!

@AnnaCouthuresIdrizi

This comment has been minimized.

Copy link
Contributor Author

AnnaCouthuresIdrizi commented Jan 15, 2020

Thank YOU for all suggestions during the last year !
Best regards,
Anna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.