[PRE REVIEW]: Enhanced software and platform for the Town Energy Balance (TEB) model #1934

whedon · 2019-12-04T14:49:13Z

Submitting author: @dmey (D. Meyer)
Repository: https://github.com/teb-model/teb
Version: 4.0.0
Editor: @mjsottile
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @dmey. Currently, there isn't an JOSS editor assigned to your paper.

@dmey if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

whedon · 2019-12-04T14:49:17Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon · 2019-12-04T14:49:18Z

Attempting to check references...

whedon · 2019-12-04T14:49:18Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-12-04T14:49:27Z

PDF failed to compile for issue #1934 with the following error:

Can't find any papers to compile :-(

danielskatz · 2019-12-04T14:50:09Z

@whedon generate pdf from joss-paper

whedon · 2019-12-04T14:50:12Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-12-04T14:50:24Z

PDF failed to compile for issue #1934 with the following error:

Can't find any papers to compile :-(

danielskatz · 2019-12-04T14:50:36Z

@whedon generate pdf from branch joss-paper

whedon · 2019-12-04T14:50:38Z

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

whedon · 2019-12-04T14:50:48Z

PDF failed to compile for issue #1934 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon/author.rb:56:in build_affiliation_string': undefined method split' for [1, 2]:Array (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon/author.rb:17:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon.rb:201:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon.rb:201:in block in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon.rb:198:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon.rb:198:in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon.rb:91:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-df8b50fe58b8/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

dmey · 2019-12-04T14:53:18Z

@danielskatz I think this may be due to the 2 affiliations (see https://github.com/teb-model/teb/blame/joss-paper/paper/paper.md#L15).

danielskatz · 2019-12-04T14:53:28Z

👋 @dmey - the multiple affiliations line needs to be of the form
affiliation: "1, 2"
with quote marks, not square brackets

Once you've made this change, you can enter a new comment in this thread with @whedon generate pdf from branch joss-paper to try again. Feel free to iterate until things look right.

dmey · 2019-12-04T14:54:56Z

@whedon generate pdf from branch joss-paper

whedon · 2019-12-04T14:55:00Z

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

whedon · 2019-12-04T14:55:12Z

PDF failed to compile for issue #1934 with the following error:

Error reading bibliography ./paper.bib (line 323, column 1):
unexpected "@"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

dmey · 2019-12-04T14:57:41Z

@whedon generate pdf from branch joss-paper

whedon · 2019-12-04T14:57:44Z

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

whedon · 2019-12-04T14:58:08Z

👉 Check article proof 📄 👈

dmey · 2019-12-04T15:00:28Z

@danielskatz many thanks -- still a few issues with the typesetting -- will try to fix this momentarily.

whedon · 2019-12-04T15:03:23Z


OK DOIs

- 10.1023/A:1002463829265 is OK
- 10.5194/gmd-5-1377-2012 is OK
- 10.5194/gmd-11-1929-2018 is OK
- 10.1002/joc.3415 is OK
- 10.5194/gmd-5-433-2012 is OK
- 10.5194/gmd-10-2801-2017 is OK
- 10.1175/WAF-D-11-00064.1 is OK
- 10.3389/fenvs.2014.00014 is OK
- 10.21105/joss.01137 is OK
- 10.5065/1dfh-6p97 is OK
- 10.1016/j.aeaoa.2019.100042 is OK
- 10.1007/s00703-008-0320-9 is OK
- 10.21105/joss.01468 is OK
- 10.1007/BF01025401 is OK
- 10.1175/2009MWR2750.1 is OK
- 10.1007/s10546-009-9414-2 is OK
- 10.1175/1520-0493(1998)126<1373:TOCMGE>2.0.CO;2 is OK
- 10.1023/A:1016509614936 is OK
- 10.1007/s10546-006-9091-3 is OK
- 10.1175/2009JAMC2153.1 is OK
- 10.5281/zenodo.3562310 is OK

MISSING DOIs

- https://doi.org/10.1175/1520-0450(2004)043<0312:mtsebo>2.0.co;2 may be missing for title: Modeling the Surface Energy Balance of the Core of an Old Mediterranean City: Marseille
- https://doi.org/10.1007/s007030070003 may be missing for title: The Advanced Regional Prediction System (ARPS) – A Multi-Scale Nonhydrostatic Atmospheric Simulation and Prediction Model. Part I: Model Dynamics and Verification
- https://doi.org/10.1007/s00585-997-0090-6 may be missing for title: The Meso-NH Atmospheric Simulation System. Part I: Adiabatic Formulation and Control Simulations
- https://doi.org/10.1175/1520-0450(2002)041<1011:eotteb>2.0.co;2 may be missing for title: Evaluation of the Town Energy Balance (TEB) Scheme with Direct Measurements from Dry Districts in Two Cities

INVALID DOIs

- None

dmey · 2019-12-04T15:12:29Z

@whedon generate pdf from branch joss-paper

whedon · 2019-12-04T15:12:32Z

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

whedon · 2019-12-04T15:13:14Z

👉 Check article proof 📄 👈

dmey · 2019-12-04T15:16:17Z

@danielskatz I have fixed the references but there is still an issue with the typesetting of footnotes. It looks like table footnotes are made part of the table itself and not of the page footer. Have you experienced a similar issue before?

danielskatz · 2019-12-04T15:44:45Z

@arfon - Any thoughts?

arfon · 2019-12-04T15:47:15Z

@arfon - Any thoughts?

No idea sorry. I think this is probably pushing the limit of the Markdown/Pandoc template sorry. I'd recommend trying to find a different way to accomplish this.

dmey · 2019-12-04T15:50:57Z

@whedon generate pdf from branch joss-paper

whedon · 2019-12-04T15:51:00Z

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

whedon · 2019-12-04T15:51:30Z

👉 Check article proof 📄 👈

dmey · 2019-12-04T15:53:08Z

No idea sorry. I think this is probably pushing the limit of the Markdown/Pandoc template sorry. I'd recommend trying to find a different way to accomplish this.

@arfon @danielskatz Thanks and not problems -- I removed the footnote and used a start (*) instead this with clarification in the caption. LGTM now but please let me know for any issues.

danielskatz · 2019-12-04T17:55:42Z

👋 @mjsottile - would you be willing to edit this submission? It's a bit out of your area, but the .F90 part makes you a potentially good option.

mjsottile · 2019-12-05T05:07:28Z

I can, but can't start the process until next week: end of semester + travel = no time for the next 7 days or so.

danielskatz · 2019-12-05T05:33:14Z

That's fine - thanks.

danielskatz · 2019-12-05T05:33:27Z

@whedon assign @mjsottile as editor

whedon · 2019-12-05T05:33:32Z

OK, the editor is @mjsottile

dmey · 2019-12-05T16:14:30Z

@mjsottile and @danielskatz many thanks for this -- In the meantime, I would like to suggest a few names from the JOSS list of reviewers that may be suitable for the review:

https://github.com/dvalters
https://github.com/bjarketol
https://github.com/tomchor
https://github.com/kramea
https://github.com/martinfleis
https://github.com/robertodr
https://github.com/nmstreethran
https://github.com/johnrobertlawson
https://github.com/brynpickering

whedon added the pre-review label Dec 4, 2019

whedon added CMake Fortran Python labels Dec 4, 2019

whedon assigned mjsottile Dec 5, 2019

Please note that GitHub no longer supports your web browser.

Sponsor openjournals/joss-reviews

openjournals/joss-reviews

Join GitHub today

[PRE REVIEW]: Enhanced software and platform for the Town Energy Balance (TEB) model #1934

Comments

whedon commented Dec 4, 2019 • edited

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

danielskatz commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

danielskatz commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

danielskatz commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

danielskatz commented Dec 4, 2019

This comment has been minimized.

arfon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

whedon commented Dec 4, 2019

This comment has been minimized.

dmey commented Dec 4, 2019

This comment has been minimized.

danielskatz commented Dec 4, 2019

This comment has been minimized.

mjsottile commented Dec 5, 2019

This comment has been minimized.

danielskatz commented Dec 5, 2019

This comment has been minimized.

danielskatz commented Dec 5, 2019

This comment has been minimized.

whedon commented Dec 5, 2019

This comment has been minimized.

dmey commented Dec 5, 2019

whedon commented Dec 4, 2019 •

edited