Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some PySpark udfs #412
Draft
+30
−6
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 40 40
Lines 1542 1542
Branches 292 292
=======================================
Hits 1196 1196
Misses 218 218
Partials 128 128 |
This comment has been minimized.
This comment has been minimized.
|
@ruebot, yes, sure, pls give the access. |
This comment has been minimized.
This comment has been minimized.
Makes sense to me! Thanks @ruebot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJan 18, 2020
•
edited
GitHub issue(s): #409
What does this Pull Request do?
How should this be tested?
https://gist.github.com/ruebot/e50892b0b2b4a6abad8ddc7933cf79b2
Additional Notes:
We need to sort out how we'll bundle something like everything that
requirements.txtwould help with in the zip file; something like the Uberjar. Right now, we really don't have anything, but I imagine we'd want to pull in external libraries like Beautiful Soup, or tld-extractor.I'll leave this as a draft, and push to it as I'm working on it. Others are welcome to push to it as well, since GitHub is now setup to provide credit to all those accounts who contributed to a PR when it is squashed down.
Interested parties
@SinghGursimran if you're sick of Scala, let me know, and I can give you access.
@lintool this approach fine? Naming convention fine?
@ianmilligan1 let me know if the notebook testing makes sense. Figured that'd be easy to test this stuff.