Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crawl_date to binary DataFrames and imageLinks. #414

Merged
merged 1 commit into from Jan 18, 2020
Merged

Conversation

@ruebot
Copy link
Member

ruebot commented Jan 18, 2020

GitHub issue(s): #413

What does this Pull Request do?

Add crawl_date to binary DataFrames and imageLinks.

  • Resolves #413
  • Update tests where necessary

How should this be tested?

TravisCI should do it.

- Resolves #413
- Update tests where necessary
@ruebot ruebot requested review from lintool and ianmilligan1 Jan 18, 2020
@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Jan 18, 2020

Looks good – I can approve + merge once TravisCI turns green!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #414 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #414      +/-   ##
=========================================
+ Coverage   77.56%   77.7%   +0.14%     
=========================================
  Files          40      40              
  Lines        1542    1552      +10     
  Branches      292     292              
=========================================
+ Hits         1196    1206      +10     
  Misses        218     218              
  Partials      128     128
@ianmilligan1 ianmilligan1 merged commit 9e357cc into master Jan 18, 2020
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 77.56%)
Details
codecov/project 77.7% (+0.14%) compared to 9277e68
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-413 branch Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.