Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upoptimize function names (removePeaks, clean) #89
Comments
sneumann
added a commit
to sneumann/Spectra
that referenced
this issue
Jan 21, 2020
Related to discussions here at the RFMF workshop (see rformassspectrometry#89 ) Yours, Steffen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
schymane commentedJan 21, 2020
Discussion at metaRbolomics, these two functions are a bit of a misnoma:
https://github.com/rformassspectrometry/Spectra/blob/master/R/Spectra.R#L401
"removePeaks" is rather "markPeaks" or something (it doesn't actually remove peaks)
Whereas "clean" is not really clean but more analogous to trim
https://github.com/rformassspectrometry/Spectra/blob/master/R/Spectra.R#L412