Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix malformed JSON for collection ID #31
+1
−1
Conversation
ianmilligan1
requested a review
from
ruebot
Mar 6, 2019
This comment has been minimized.
This comment has been minimized.
|
My bad. |
ruebot
approved these changes
Mar 6, 2019
This comment has been minimized.
This comment has been minimized.
|
Let's get this one in now. It's an easy change for @greebie to pull into his work. |
ianmilligan1
marked this pull request as ready for review
Mar 6, 2019
ianmilligan1
requested a review
from
greebie
Mar 6, 2019
This comment has been minimized.
This comment has been minimized.
|
Ok I have marked this as ready for review. @greebie can you review + merge? |
This comment has been minimized.
This comment has been minimized.
|
Or actually, I guess @SamFritz can review too since she was in the room and verified that this works! |
This comment has been minimized.
This comment has been minimized.
|
I recloned the repo so I'll be able to do a walk through with a fresh slate. Will let you know if anything seems amiss. |
greebie
approved these changes
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Let's get #30 finished then. |
ruebot
closed this
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Almost there. Just fixing a few tiny bugs and we should be good to go in the next commit.. |
ruebot
deleted the
json-fix
branch
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
this now works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedMar 6, 2019
@SamFritz and I were doing some local testing on master and got the following error (on both of our systems):
Somewhere along the line when the collection ID was added in, an escape went mixing which threw off the full cell. This branch works on both of our systems now.
I'm not sure how this happened as it was definitely working locally earlier.
@greebie is currently working on a branch though. So maybe you just want to make sure that it works, so this is more just to have a branch that works (I have it at draft right now).