Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCopyediting. #35
Conversation
ruebot
requested review from
ianmilligan1
and
SamFritz
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
I'm sorry - I was sure I had all those fixed. Somewhere between Jupyter and git, I'm losing my edits. |
ianmilligan1
approved these changes
Mar 7, 2019
SamFritz
reviewed
Mar 7, 2019
|
Nice job @greebie! This is looking really great. Just a three suggestions I will list here as I am unable to make inline comments for grey code within auk-notebook.ipynb
|
SamFritz
approved these changes
Mar 7, 2019
ianmilligan1
merged commit 5e0db61
into
master
Mar 7, 2019
1 check passed
ci/dockercloud
Your tests passed in Docker Cloud
Details
ianmilligan1
deleted the
copyediting-2
branch
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedMar 7, 2019
No description provided.