Skip to content

/auk-notebooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup notebook to run with au_notebook as a library; resolves #50 #52

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Reviewers

@greebie greebie

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Copy link
Member

commented Apr 11, 2019 •
edited

  • Update Dockerfile
  • Update README
  • Update notebook to use au_notebook library
  • Remove library

Test this out. If y'all are cool with it, I'll proceed on getting au_notebook setup on PyPi, and push a 0.0.1 release so we can use that.

We'll want to do this before #51 is merged.
@ruebot
Setup notebook to run with au_notebook as a library; resolves #50 
- Update Dockerfile
- Update README
- Update notebook to use au_notebook library
- Remove library
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
a8e65bc

@ruebot ruebot requested review from greebie and ianmilligan1 Apr 11, 2019

@ianmilligan1

ianmilligan1 approved these changes Apr 11, 2019
View changes

Copy link
Member

left a comment

Tested both locally + with Docker, all checks out well.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 11, 2019

Here's the repo on the test PyPi: https://test.pypi.org/project/au-notebook/
@ruebot
remove more cruft
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d7f688c
@greebie

greebie approved these changes Apr 12, 2019
View changes

Copy link
Collaborator

left a comment

Works fine for me!
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 12, 2019

Cool. I'll cut a 0.0.1 release of au_notebook, and update this PR.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 12, 2019

https://pypi.org/project/au-notebook/
@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Apr 12, 2019

Reminder that you may have to uninstall au_notebook first if you pip installed the test version (I was wondering how I ended up with a 0.0.2 version).
@ruebot
Add au_notebook to requirements
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
1f58aef

@ruebot ruebot marked this pull request as ready for review Apr 12, 2019

@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 12, 2019

Sorry, had to push another release to PyPI. Missed a bad typo that cause the library note to fully load 🤦‍♂️

It all should be good to go now.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 12, 2019

The original commit message should be good when y'all squash and merge. If you have any questions, let me know.

Screenshot from 2019-04-12 14-29-04
@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Apr 12, 2019

Oh thank goodness. I was going crazy trying to figure out why I couldn't get it to import! :) Works great now.

@ianmilligan1 ianmilligan1 merged commit e5f78a4 into master Apr 15, 2019
1 check passed

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the au_notebook-library branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.