Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #336

Merged
merged 6 commits into from Jul 31, 2019
+101 −16

Conversation

@ruebot
Copy link
Member

commented Jul 31, 2019

Checking this branch against CodeCov to see what happens before I consider deleting it.

jrwiebe and others added some commits Jan 31, 2019

@jrwiebe
Test class DataFrame Loader; resolves #265
a4a31d9
@jrwiebe
Remove unnecessary $-notation code
1702fbb
@jrwiebe
Update SaveImage Scaladoc
feccceb
@jrwiebe
Test SaveImage with invalid image; partly resolves #264
Loading status checks…
01f3f71
@ruebot
Merge branch 'master' into tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc1e214
@ruebot
Update tests
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
9f7e049
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jul 31, 2019

Codecov Report

Merging #336 into master will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage      75%   75.97%   +0.97%     
==========================================
  Files          39       39              
  Lines        1124     1124              
  Branches      197      197              
==========================================
+ Hits          843      854      +11     
+ Misses        215      205      -10     
+ Partials       66       65       -1
Impacted Files Coverage Δ
...c/main/scala/io/archivesunleashed/df/package.scala 95.23% <ø> (+4.76%) ⬆️
...n/scala/io/archivesunleashed/DataFrameLoader.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c1f1f...9f7e049. Read the comment docs.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 31, 2019

Cool. Looks like we resolve #265 and I'd mark #263 as closed too since it'll be up around 99% covered.

@ianmilligan1 if you're good with this, I'll write a commit message, and highlight @jrwiebe's work on this in the message.
@ianmilligan1

ianmilligan1 approved these changes Jul 31, 2019
View changes

Copy link
Member

left a comment

Looks good to me, @ruebot. If you provide commit message I can squash+merge.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 31, 2019 •
edited 

Update test coverage for data frames (#336).

- This commit will fall under @ruebot, but @jrwiebe did the heavy lifting here; see #336 for his commits before they were squashed down.
- Resolves #265
- Resolves #263
- Remove unnecessary $-notation code
- Update Scaladocs

@ianmilligan1 ianmilligan1 merged commit 605afcc into master Jul 31, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing 64c1f1f...9f7e049
Details
codecov/project 75.97% (+0.97%) compared to 64c1f1f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the tests branch Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ruebot @codecov-io @ianmilligan1 @jrwiebe
You can’t perform that action at this time.