Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd discardLanguage filter to RecordLoader. #353
Conversation
ruebot
requested a review
from ianmilligan1
Aug 21, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Aug 22, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 75.91% 75.93% +0.01%
==========================================
Files 39 39
Lines 1387 1388 +1
Branches 265 266 +1
==========================================
+ Hits 1053 1054 +1
Misses 218 218
Partials 116 116 |
ianmilligan1
approved these changes
Aug 23, 2019
ianmilligan1
merged commit 0284d33
into
master
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedAug 21, 2019
GitHub issue(s): #352
What does this Pull Request do?
How should this be tested?