Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keepValidPages to include a filter on 200 OK. #360

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@ruebot
Copy link
Member

commented Sep 11, 2019

GitHub issue(s): #359

What does this Pull Request do?

  • Add status code filter to keepValidPages
  • Add MimeTypeTika to valid pages DF
  • Update tests since we filter more and better now 😄
  • Resolves #359

How should this be tested?

  • TravisCI should take care of it, but sanity testing would be good if you have the time @ianmilligan1

Additional Notes:

  • I'll look at the documentation, and see if anything needs to be updated
@ruebot
Update keepValidPages to include a filter on 200 OK.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
295769b 
- Add status code filter to keepValidPages
- Add MimeTypeTika to valid pages DF
- Update tests since we filter more and better now 😄
- Resolves #359
@ruebot ruebot requested a review from ianmilligan1 Sep 11, 2019
@codecov

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

Codecov Report

Merging #360 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   75.93%   75.93%   -0.01%     
==========================================
  Files          39       39              
  Lines        1388     1392       +4     
  Branches      266      267       +1     
==========================================
+ Hits         1054     1057       +3     
  Misses        218      218              
- Partials      116      117       +1
@ianmilligan1
ianmilligan1 approved these changes Sep 11, 2019
View changes
Copy link
Member

left a comment

Built and tested locally - all checks out. For fun, I ran a diff on the file using this branch vs. the 0.18.0 release. Here are the things that no longer appear in the plain text output.

Screen Shot 2019-09-11 at 2 46 44 PM

If you keep scrolling it's this stuff over and over again, so I'd say this is a major enhancement. Great stuff, @ruebot !
@ianmilligan1 ianmilligan1 merged commit 9b3e025 into master Sep 11, 2019
3 checks passed
3 checks passed
codecov/patch 85.71% of diff hit (target 75.93%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +9.77% compared to 7305ed7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-359 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.