Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAppend UDF with RDD or RF. #381
Conversation
This comment has been minimized.
This comment has been minimized.
|
@SinghGursimran once we get this merged, this should be a solid implementation pattern for you as we sort out the rest of #223. @lintool all the names make me cringe a bit, but it makes things a lot clearer now. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 40 40
Lines 1422 1422
Branches 268 268
=======================================
Hits 1084 1084
Misses 221 221
Partials 117 117 |
This comment has been minimized.
This comment has been minimized.
|
Oh. Lots of documentation updates to do. I've started a local branch. |
ruebot
added a commit
to archivesunleashed/aut-docs-new
that referenced
this pull request
Nov 19, 2019
This comment has been minimized.
This comment has been minimized.
|
Documentation PR: archivesunleashed/aut-docs-new#24 |
|
LGTM - the names are messy, as you note, but it'll keep things straight. |
ianmilligan1
added a commit
to archivesunleashed/aut-docs-new
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedNov 19, 2019
GitHub issue(s): #223
What does this Pull Request do?
Append UDF with RDD or RF.
How should this be tested?
Additional Notes:
There might be some documentation updates to do.