Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd and update tests, resolve textFiles bug. #388
Merged
+276
−50
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 16, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=========================================
+ Coverage 75.97% 76.87% +0.9%
=========================================
Files 41 40 -1
Lines 1469 1466 -3
Branches 274 274
=========================================
+ Hits 1116 1127 +11
+ Misses 236 217 -19
- Partials 117 122 +5 |
- Add ExtractDateDF test - Fix conditional logic of textFiles filter to resolve #390 - Add test for conditional logic fix for #390 - Remove cruft ExtractUrls, left over from Twitter analysis removal (see: https://github.com/lintool/warcbase/blob/cab311ed8b0bceb666865fa76dd3bc5a86402e13/warcbase-core/src/test/scala/org/warcbase/spark/matchbox/ExtractUrlsTest.scala) - Tweak null/nothing on a few tests
ruebot
changed the title
|
LGTM - tested using the script in #390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedDec 16, 2019
•
edited
GitHub issue(s):
What does this Pull Request do?
(see:
https://github.com/lintool/warcbase/blob/cab311ed8b0bceb666865fa76dd3bc5a86402e13/warcbase-core/src/test/scala/org/warcbase/spark/matchbox/ExtractUrlsTest.scala)
How should this be tested?