/warclight

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.64.0 #61

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
2 participants
@codecov-io @ruebot
@depfu
Copy link
Contributor

depfu bot commented Feb 11, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.63.0 → ~> 0.64.0) · Repo · Changelog

Release Notes

0.64.0

New features

  • #6704: Add new Rails/ReflectionClassName cop. (@Bhacaz)
  • #6643: Support AllowParenthesesInCamelCaseMethod option on Style/MethodCallWithArgsParentheses omit_parentheses. (@dazuma)

Bug fixes

  • #6254: Fix Layout/RescueEnsureAlignment for non-local assignments. (@marcotc)
  • #6648: Fix auto-correction of Style/EmptyLiteral when Hash.new is passed as the first argument to super. (@rrosenblum)
  • #6351: Fix a false positive for Layout/ClosingParenthesisIndentation when first argument is multiline. (@antonzaytsev)
  • #6689: Support more complex argument patterns on Rails/Validation auto-correction. (@r7kamura)
  • #6668: Fix autocorrection for Style/UnneededCondition when conditional has the unless form. (@mvz)
  • #6382: Fix Layout/IndentationWidth with Layout/EndAlignment set to start_of_line. (@dischorde, @siegfault, @mhelmetag)
  • #6710: Fix Naming/MemoizedInstanceVariableName on method starts with underscore. (@pocke)
  • #6722: Fix an error for Style/OneLineConditional when then branch has no body. (@koic)
  • #6702: Fix TrailingComma regression where heredoc with commas caused false positives. (@abrom)
  • #6737: Fix an incorrect auto-correct for Rails/LinkToBlank when link_to method arguments are enclosed in parentheses. (@koic)
  • #6720: Fix detection of :native line ending for Layout/EndOfLine on JRuby. (@enkessler)

Changes

  • #6597: Style/LineEndConcatenation is now known to be unsafe for auto-correct. (@jaredbeck)
  • #6725: Mark Style/SymbolProc as unsafe for auto-correct. (@drenmi)
  • #6708: Make Style/CommentedKeyword allow the :yields: RDoc comment. (@bquorning)
  • #6749: Make some cops aware of safe navigation operator. (@hoshinotsuyoshi)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu
Update rubocop to version 0.64.0
Loading status checks…
121111a

@depfu depfu bot added the depfu label Feb 11, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Feb 11, 2019 •
edited

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9b373...121111a. Read the comment docs.

@ruebot ruebot merged commit c35d7c5 into master Feb 11, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing ca9b373...121111a
Details
codecov/project 100% remains the same compared to ca9b373
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.64.0 branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment