Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up test descriptions, addresses #372. #416
Merged
+130
−130
Conversation
|
These look great (and I'll leave the the actual tests to TravisCI). Some half hearted comments re: copy editing, which you can take or leave. |
src/test/scala/io/archivesunleashed/app/WriteGraphXMLTest.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 21, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 41 41
Lines 1570 1570
Branches 292 292
=======================================
Hits 1224 1224
Misses 218 218
Partials 128 128 |
This comment has been minimized.
This comment has been minimized.
|
Ok, I'll put those back in. I stand corrected. |
| @@ -43,21 +43,21 @@ class RecordRDDTest extends FunSuite with BeforeAndAfter { | |||
| sc = new SparkContext(conf) | |||
| } | |||
|
|
|||
| test("no valid pages") { | |||
| test("Expect no valid pages") { | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJan 21, 2020
GitHub issue(s): #372
What does this Pull Request do?
How should this be tested?