Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/ styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update american-chemical-society.csl #4270

Merged
merged 1 commit into from Aug 23, 2019
Merged

Update american-chemical-society.csl #4270

merged 1 commit into from Aug 23, 2019

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Aug 23, 2019

Fix issue with publisher-punctuation for thesis in ACS style as mentioned here: #4260

(No idea how to deal with the other issue(s))
@POBrien333
Update american-chemical-society.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d05a5b 
Fix issue with publisher-punctuation for thesis in ACS style as mentioned here: #4260

(No idea how to deal with the other issue(s))
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Aug 23, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Aug 23, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

american-chemical-society.csl (modified style; unchanged output for sample items)
1,2
3,4
(1) Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy; Hancké, B., Rhodes, M., Thatcher, M., Eds.; Oxford University Press: Oxford and New York, 2007.
(2) CSL search by example http://editor.citationstyles.org/searchByExample/ (accessed Dec 15, 2012).
(3) Mares, I. Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers? In Varieties of capitalism. The institutional foundations of comparative advantage; Hall, P. A., Soskice, D., Eds.; Oxford University Press: New York, 2001; pp 184–213.
(4) Fenner, M.; Crosas, M.; Grethe, J. S.; Kennedy, D.; Hermjakob, H.; Rocca-Serra, P.; Durand, G.; Berjon, R.; Karcher, S.; Martone, M.; et al. A Data Citation Roadmap for Scholarly Data Repositories. Scientific Data 2019, 6 (1), 28. https://doi.org/10.1038/s41597-019-0031-8.
@adam3smith adam3smith merged commit 6db15df into citation-style-language:master Aug 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Aug 23, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@POBrien333 @csl-bot @adam3smith
You can’t perform that action at this time.