Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BFCN.csl #4481

Merged
merged 5 commits into from Jan 1, 2020
Merged

Create BFCN.csl #4481

merged 5 commits into from Jan 1, 2020

Conversation

@pgiraudoux
Copy link
Contributor

pgiraudoux commented Dec 31, 2019

This file corresponds to the style requirements of Bourgogne Franche-Comté Nature

This file corresponds to the style requirements of Bourgogne Franche-Comté Nature
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😟 There are some issues with your submission.

Please check the test report for details.

Sorry, I forgot to quote the threads lines 8-10 in the earlier version
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😟 There are some issues with your submission.

1 test failed

BFCN: must have a conventional file name

expected "BFCN.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"BFCN.csl"

Please check the test report for details.

@pgiraudoux

This comment has been minimized.

Copy link
Contributor Author

pgiraudoux commented Dec 31, 2019

OK. I forgot to quote the thread lines 8-10; I have edited the code accordingly, and now it went through the CSL validator.

@pgiraudoux

This comment has been minimized.

Copy link
Contributor Author

pgiraudoux commented Dec 31, 2019

I have changed the file name BFCN.csl to lowercase bfcn.csl

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😟 There are some issues with your submission.

Please check the test report for details.

@pgiraudoux

This comment has been minimized.

Copy link
Contributor Author

pgiraudoux commented Dec 31, 2019

BFCN changed to bfcn where appropriate

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Dec 31, 2019

@pgiraudoux, thanks. Is there a webpage that describes the style requirements? And does the journal have outside contributors that need to submit their manuscripts formatted according to the journal's style requirements?

@pgiraudoux

This comment has been minimized.

Copy link
Contributor Author

pgiraudoux commented Dec 31, 2019

Not at this stage. We are just processing an author instruction webpage, but this will not be ready before some weeks. Of course contributors are already strongly encouraged to use csl style for their MS submission, and will be more formally invited to do so when the page is ready. For the moment, the documentation link points to the journal website.
Kind regards,

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 1, 2020

We are just processing an author instruction webpage, but this will not be ready before some weeks.

Great. Could you report back here when that page is live?

@rmzelle rmzelle merged commit c236ade into citation-style-language:master Jan 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 1, 2020

Thanks!

@pgiraudoux

This comment has been minimized.

Copy link
Contributor Author

pgiraudoux commented Jan 1, 2020

Great. Could you report back here when that page is live?

Yes, of course, I will also modify the link "document" in the csl file accordingly to point to the page "instructions to authors" and commit the modif. Thanks for your concern. Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.