Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged term on access macro, added rules for bill #4407
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 13, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 13, 2019
Below are some sample citations generated based on your proposed changes: university-of-lincoln-harvard.csl (modified style; unchanged output for sample items)(Hancké et al., 2007; CSL search by example, 2012) |
<text term="available at" text-case="capitalize-first" suffix=" "/> | ||
<text variable="URL"/> | ||
<if type="bill webpage article-journal article-newspaper" match="any"> | ||
<text variable="URL" prefix="Available from "/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Nov 14, 2019
Member
I don't understand why you switched this? Using the term should give you exactly the same and is generally preferable (e.g., makes the style more robust for adaptation)
This comment has been minimized.
This comment has been minimized.
abeeken
Nov 14, 2019
Author
Contributor
Hi Sebastian,
We switched this as for some reason the term wasn't appearing for a "bill" type citation - using the prefix worked fine.
This comment has been minimized.
This comment has been minimized.
adam3smith
Nov 15, 2019
Member
that really shouldn't matter and we don't like to work around bugs in citation managers. Was that in Zotero or a different tool?
This comment has been minimized.
This comment has been minimized.
abeeken
Nov 15, 2019
Author
Contributor
No, it was while we were building the style in the CSL editor: https://editor.citationstyles.org/visualEditor/
This comment has been minimized.
This comment has been minimized.
adam3smith
Nov 16, 2019
Member
Could you walk me through steps to reproduce that? It really shouldn't happen (and I'm quite surprised it would, so I'm suspecting something else may have been going on), but if it does it's a bug in the editor we want to fix rather than to fix something in the style that isn't broken (e.g. I just tested in Zotero and using the term for the bill is fine).
This comment has been minimized.
This comment has been minimized.
abeeken
Nov 18, 2019
Author
Contributor
I've checked myself and I can't actually reproduce it - not sure what was going on when I was working on this but I've put the tag back in and it's rendering fine now
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 18, 2019
1 test faileduniversity-of-lincoln-harvard: must validate against the CSL 1.0.1 schema
Please check the test report for details. |
This comment has been minimized.
This comment has been minimized.
(I'll fix validation; don't worry about it) |
...to prevent unwanted terms
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 18, 2019
Below are some sample citations generated based on your proposed changes: university-of-lincoln-harvard.csl (modified style; unchanged output for sample items)(Hancké et al., 2007; CSL search by example, 2012) |
abeeken commentedNov 13, 2019
No description provided.