Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create discovery-medicine.csl #2399

Merged
merged 6 commits into from Jan 13, 2017
Merged

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Jan 6, 2017

https://forums.zotero.org/discussion/56278/style-request-discovery-medicine/
Checked with actual publications for books/chapters as not specified in guidelines

https://forums.zotero.org/discussion/56278/style-request-discovery-medicine/p1
Checked with actual publications for books/chapters as not specified in guidelines
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 6, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 6, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 6, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 6, 2017

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Some minor comments.

</if>
<else-if type="chapter paper-conference" match="any">
<text term="in" text-case="capitalize-first" font-style="italic" suffix=": "/>
<group delimiter=". " prefix=" " suffix=". ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 7, 2017

Member

no need for the prefix here. You have a space from the suffix above.

</else>
</choose>
</macro>
<citation et-al-min="3" et-al-use-first="1" disambiguate-add-year-suffix="true" disambiguate-add-names="true" disambiguate-add-givenname="true" collapse="year">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 7, 2017

Member

delete: disambiguate-add-names="true":
"If there are multiple references with the same first author and same publishing year, please add a letter after the year to differentiate the references"
(With the preference it would add additional names if the 2nd, 3rd etc. author are different)

<macro name="author">
<names variable="author" suffix=". ">
<name sort-separator=" " initialize-with="" name-as-sort-order="all" delimiter=", " delimiter-precedes-last="always"/>
</names>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 7, 2017

Member

I always make sure the substitute elements in author-date styles conform between author and author-short macro. Otherwise, how would authors find the bib entry corresponding to a citation? In other words, add editor, translator, and title as substitute elements here.
With the editor and translator now options, I would then also suggest adding <label form="short" prefix=" (" suffix=")"/>

<link href="http://www.zotero.org/styles/brain" rel="template"/>
<link href="http://www.discoverymedicine.com/about/information-for-authors-of-discovery-medicine/" rel="documentation"/>
<author>
<name>O'Brien Patrick, PhD</name>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jan 8, 2017

Member

@damnation333, do you care about the order here? I've been changing a few <name>O'Brien Patrick, PhD</name> to <name>Patrick O'Brien, PhD</name> in recent submissions.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 8, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 10, 2017

@adam3smith, I let this sit because the "author" and "author-short" macros still not fully align ("author" has no title substitution). Do you want to see that changed?

I hope I did this right now. Had this sitting around, as I wasn't sure.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 11, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 13, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 8855661 into citation-style-language:master Jan 13, 2017
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 13, 2017

Thanks!

@POBrien333 POBrien333 mentioned this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.