Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Harvard1 into dependent #2610

Merged
merged 3 commits into from Apr 3, 2017
Merged

Turn Harvard1 into dependent #2610

merged 3 commits into from Apr 3, 2017

Conversation

@adam3smith
Copy link
Member

adam3smith commented Apr 1, 2017

Turn Harvard1 into dependent of Harvard Cite Them Right. Still not getting rid of it, but at least
it's following a clear guide. Redirect all templates.

Follow-up of #2514 (comment).

of Harvard Cite Them Right. Still not getting rid of it, but at least
it's following a clear guide. Redirect all templates
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member Author

adam3smith commented Apr 1, 2017

@rmzelle -- since this one is larger, I'm leaving it for you to merge, but gtg from my side.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 2, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Apr 2, 2017

@adam3smith, I'm kicking the ball back to you. If you agree with my changes feel free to squash-merge. I added some explanation in the style's summary. I also removed the "author-date" in the title (replacing it by "retired") and removed the "generic-base" category to put as little emphasis as possible on the style.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Apr 2, 2017

Also, slightly off-topic, the "documentation" link for https://github.com/citation-style-language/styles/blob/master/harvard-cite-them-right.csl is a bit weird. Should we link to https://he.palgrave.com/page/detail/Cite-Them-Right/?K=9781137585042 instead? I also noticed that the 10th edition was released in May 2016, while we're still on the 9th.

@adam3smith

This comment has been minimized.

Copy link
Member Author

adam3smith commented Apr 2, 2017

Looks good. Two questions & 1 update:

  1. How about "deprecated" rather than "retired"? The latter sounds odd to me
  2. For the style guide link: The current one won't do, obviously, since the link doesn't lead anywhere. We can link to either the book or the website for it (http://www.citethemrightonline.com/) but both are obviously not universally accessible. Alternatively, we could link to a freely available summary: https://www.canterbury.ac.uk/library/docs/harvard.pdf I'd be inclined to do the latter or both. Thoughts?
  3. I'll update to the 10th edition. Fortunately, changes are minimal.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 3, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 1cda6d6 into master Apr 3, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rmzelle rmzelle deleted the delete-harvard1 branch Apr 3, 2017
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Apr 3, 2017

Great, thanks. Maybe link to the "online" website and the summary, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.