Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create acta-orthopaedica-belgica.csl #2795

Merged
merged 7 commits into from Jul 7, 2017

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Jul 6, 2017

via https://forums.zotero.org/discussion/66369/style-request-acta-orthopaedica-belgica
Adapted for journals and books (and chapters based on the requestor, but nothing in the guidelines and the requestor made some mistakes for the Campbell example. Can't be trusted)

via https://forums.zotero.org/discussion/66369/style-request-acta-orthopaedica-belgica#latest
Adapted for journals and books (and chapters based on the requestor, but nothing in the guidelines and the requestor made some mistakes for the Campbell example. Can't be trusted)
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 6, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 6, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 6, 2017

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Please check over my questions. Also, if you can run a search & replace to get rid of all the redundant form="long"?

<sort>
<key variable="citation-number" sort="ascending"/>
</sort>
<layout font-style="italic" delimiter=" ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 7, 2017

Member

I'm suspecting this isn't right? citations are really (1) (2) (3) instead of (1, 2) and (1-3)?

</sort>
<layout suffix=".">
<text variable="citation-number" font-weight="bold" suffix="."/>
<text macro="author" text-case="capitalize-first" strip-periods="true" suffix=". "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 7, 2017

Member

I don't think you want to run capitalize-first and strip-periods on a whole macro, do you?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 7, 2017

😟 There are some issues with your submission. Please check the test report for details.

Thank you for noticing those two issues. Remnants from the template style.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 7, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 7, 2017

😟 There are some issues with your submission. Please check the test report for details.

Thanks, Rintze.
I'm away for the weekend and only got my phone to work with now.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 7, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 7, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 8fd457b into citation-style-language:master Jul 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.