Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move colon out of group for conference papers #3501

Merged
merged 1 commit into from May 10, 2018

Conversation

@feldi-online
Copy link
Contributor

feldi-online commented May 9, 2018

The term colon inside the group with ", " delimiter resulted in a wrong rendering, always "[...], in:, [...]" for conference papers, see citation 3 in the picture:

image

Matthias Feldotto
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 9, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 9, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit e17618a into citation-style-language:master May 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented May 10, 2018

Good catch! Thanks!

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented May 10, 2018

(I also checked the other Elsevier CSL styles, and none of them seem to suffer from the same issue)

@feldi-online feldi-online deleted the feldi-online:patch-1 branch May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.