Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dsh-harvard.csl #4387

Merged
merged 5 commits into from Nov 9, 2019
Merged

Conversation

@fedormyskin
Copy link
Contributor

fedormyskin commented Nov 1, 2019

I created a style for the journal Digital Scholarship in the Humanities (DSH)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 1, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 1, 2019

😟 There are some issues with your submission.

4 tests failed

dependent/dsh-harvard: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en-GB" page-range-format="minimal" demote-non-dropping-particle="sort-only" and="text" children=[5]>.dependent?` to return true, got nil

dependent/dsh-harvard: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/dsh-harvard: may not have <macro/>, <citation/>, or <bibliography/> elements

expected #has_macro? to return false, got true

dependent/dsh-harvard: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 1, 2019

(let me fix the basic validation and we can then discuss further)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 1, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dsh-harvard.csl (new)
(Hancké et al., 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL Search by Example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner, M. et al. (2019). A Data Citation Roadmap for Scholarly Data Repositories. Scientific Data, 6(1), p. 28. 10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M. and Thatcher, M.. (eds.)(eds.) (2007). Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, I.. (2001). Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers? In Hall, P.A. and Soskice, D. (eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. New York: Oxford University Press, pp. 184–213.
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 1, 2019

Thanks! Some questions:

  1. Does the journal document the style online? If so, where?
  2. Did you start from an existing style in creating this? Which?
  3. Does the journal allow for different citation styles (e.g. a Harvard and a footnote style) or is this the only one (in which case we'd remove the "Harvard" label)
@fedormyskin

This comment has been minimized.

Copy link
Contributor Author

fedormyskin commented Nov 1, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

digital-scholarship-in-the-humanities.csl (new)
(Hancké et al., 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL Search by Example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner, M. et al. (2019). A Data Citation Roadmap for Scholarly Data Repositories. Scientific Data, 6(1), p. 28. 10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M. and Thatcher, M. (eds.)(eds.) (2007). Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, I. (2001). Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers? In Hall, P.A. and Soskice, D. (eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. New York: Oxford University Press, pp. 184–213.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

digital-scholarship-in-the-humanities.csl (new)
(Hancké et al., 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL Search by Example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner, M. et al. (2019). A Data Citation Roadmap for Scholarly Data Repositories. Scientific Data, 6(1), p. 28. 10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M. and Thatcher, M. (eds.) (2007). Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, I. (2001). Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers? In Hall, P.A. and Soskice, D. (eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. New York: Oxford University Press, pp. 184–213.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

digital-scholarship-in-the-humanities.csl (new)
(Hancké et al., 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL Search by Example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner, M. et al. (2019). A Data Citation Roadmap for Scholarly Data Repositories. Scientific Data, 6(1), p. 28. 10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M. and Thatcher, M. (eds) (2007). Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, I. (2001). Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers? In Hall, P.A. and Soskice, D. (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. New York: Oxford University Press, pp. 184–213.
@adam3smith adam3smith merged commit 2d0de83 into citation-style-language:master Nov 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.