Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iso690-full-note-cs.csl #4480

Merged
merged 7 commits into from Dec 31, 2019
Merged

Conversation

@OTristanF
Copy link
Contributor

OTristanF commented Dec 30, 2019

Most importantly, added ibidem. Also fixed the missing italic in the subsequent citations.

Most importantly, added ibidem. Also fixed the missing italic in the subsequent citations.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😟 There are some issues with your submission.

1 test failed

iso690-full-note-cs: may not have any unused macros

expected: []
     got: ["contributors-short"]

(compared using ==)

Please check the test report for details.

fixed contributors-short
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

iso690-full-note-cs.csl (modified style; unchanged output for sample items)
HANCKÉ, B., RHODES, M., THATCHER, M. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007; CSL search by example. In: Citation Style Editor [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/
MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P.A., SOSKICE, D. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001; FENNER, M. et al. A data citation roadmap for scholarly data repositories. Scientific Data [online]. 2019, roč. 6, č. 1 [cit. 27.04.2019]. DOI: 10.1038/s41597-019-0031-8

CSL search by example. In: Citation Style Editor [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/
FENNER, Martin et al. A data citation roadmap for scholarly data repositories. Scientific Data [online]. 2019, roč. 6, č. 1, s. 28 [cit. 27.04.2019]. ISSN 2052-4463. DOI: 10.1038/s41597-019-0031-8
HANCKÉ, Bob, RHODES, Martin, THATCHER, Mark. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A., SOSKICE, David. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001, s. 184-213.
fixed secondary-contributors to match the documentation
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😃 Your submission passed all our automated tests.

I have changed name-as-sort-order from "all" to "first" to match the documentation.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😃 Your submission passed all our automated tests.

added "and" instead of a delimiter ", " preceding last
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

iso690-full-note-cs.csl (modified style)
HANCKÉ, B., M. RHODES a M. THATCHER. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007; CSL search by example. In: Citation Style Editor [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/
MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P.A. a D. SOSKICE. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001; FENNER, M. et al. A data citation roadmap for scholarly data repositories. Scientific Data [online]. 2019, roč. 6, č. 1 [cit. 27.04.2019]. DOI: 10.1038/s41597-019-0031-8

CSL search by example. In: Citation Style Editor [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/
FENNER, Martin et al. A data citation roadmap for scholarly data repositories. Scientific Data [online]. 2019, roč. 6, č. 1, s. 28 [cit. 27.04.2019]. ISSN 2052-4463. DOI: 10.1038/s41597-019-0031-8
HANCKÉ, Bob, Martin RHODES a Mark THATCHER. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A. a David SOSKICE. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001, s. 184-213.
-HANCKÉ, B., RHODES, M., THATCHER, M. eds. <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007; CSL search by example. In: <i>Citation Style Editor</i> [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/<br/>
-MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P.A., SOSKICE, D. eds. <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press, 2001; FENNER, M. et al. A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> [online]. 2019, roč. 6, č. 1 [cit. 27.04.2019]. DOI: 10.1038/s41597-019-0031-8<br/>
+HANCKÉ, B., M. RHODES a M. THATCHER. eds. <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007; CSL search by example. In: <i>Citation Style Editor</i> [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/<br/>
+MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P.A. a D. SOSKICE. eds. <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press, 2001; FENNER, M. et al. A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> [online]. 2019, roč. 6, č. 1 [cit. 27.04.2019]. DOI: 10.1038/s41597-019-0031-8<br/>
 <hr/>
 CSL search by example. In: <i>Citation Style Editor</i> [online] [cit. 15.12.2012]. Dostupné z: http://editor.citationstyles.org/searchByExample/<br/>
 FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> [online]. 2019, roč. 6, č. 1, s. 28 [cit. 27.04.2019]. ISSN 2052-4463. DOI: 10.1038/s41597-019-0031-8<br/>
-HANCKÉ, Bob, RHODES, Martin, THATCHER, Mark. eds. <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.<br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A., SOSKICE, David. eds. <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press, 2001, s. 184-213.<br/>
+HANCKÉ, Bob, Martin RHODES a Mark THATCHER. eds. <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.<br/>
+MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A. a David SOSKICE. eds. <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press, 2001, s. 184-213.<br/>
turned off initialization and fixed prefix of "ed"
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2019

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 25d40cd into citation-style-language:master Dec 31, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Dec 31, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.