Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upBryn mawr #1115
Conversation
Jmuccigr
and others
added some commits
Apr 7, 2016
adam3smith
reviewed
Aug 22, 2016
var items = {}; | ||
var found = false; | ||
var rows = ZU.xpath(doc, '//*[@id="indexcontent"]//li//a'); | ||
Z.debug(rows.length); |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 22, 2016
Collaborator
comment out (or if you think it's useful, add a descriptor, but I don't think so)
adam3smith
reviewed
Aug 22, 2016
|
||
var title = ZU.xpathText(doc, '//h3/i'); | ||
item.title = "Review of: " + Zotero.Utilities.trimInternal(title); | ||
var title = title.replace("(", "\\(").replace(")", "\\)"); |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 22, 2016
Collaborator
this isn't your code, but I find it confusing: it doesn't do anything useful, title
isn't used again so it's pointless, and var
isn't needed. If I'm right, delete. Otherwise remove var
Jmuccigr
reviewed
Aug 22, 2016
if (m) { | ||
item.extra = "BMCR ID: " + m[1] + "." + m[2] + "." + m[3]; | ||
item.date = m[1] + "-" + m[2]; | ||
} |
This comment has been minimized.
This comment has been minimized.
Jmuccigr
Aug 22, 2016
•
Contributor
This should actually work from 1998 on. For years between 1994 and 1997 inclusively, the match is
/(\d{2})\.(\d{2})\.(\d{2})/);
and then we've got:
item.date = "19" + m[1] + "-" + m[2];
See this page for the change in numbering method.
In earlier years (1990-1993), the year isn't included, but the URL ends with 01…
where 01 = 1990, 02 is 1991, 03 is 1992, and 04 is 1993. There's no month indicator for those years, so it's just a year. That could be taken care of by checking m[1] in the 2-digit example just given and if < 5, add 1989 to it, then make that the date.
This comment has been minimized.
This comment has been minimized.
Please have a look at the new version. @adam3smith You are absolutely right about the unnecessary line and the comment. I delete those. @Jmuccigr I added the different cases depending on the year. However, it looks like the HTML is not always consistent in the older years and therefore the translator might or might not work with older years. It should work for 1999ff. |
This comment has been minimized.
This comment has been minimized.
I'm not surprised that it's inconsistent. I might be able to get the editors to fix that. Let me look into it. Which run of years do you mean? |
This comment has been minimized.
This comment has been minimized.
Well, I tried to run the translators on the archives-by-year, e.g. http://bmcr.brynmawr.edu/1998/indexb.html which contains e.g. http://bmcr.brynmawr.edu/1998/98.1.02.html but I encountered more differences in the older years... |
This comment has been minimized.
This comment has been minimized.
Yeah, in 97 and 98 there are a few months where they didn't prefix a 0 on the month portion of the URL, so, e.g., they're 98-1-21 instead of 98-01-21. One example of this in the 1991 series beginning "02" as well. Might be easier to handle this here rather than asking them to fix a few dozen. Three of them also have a "b" at the end of the number, all before 1999 when things got pretty regular. Checking for that with a What do you think? |
This comment has been minimized.
This comment has been minimized.
The url is okay and IMO we are currently handling all of them. But the content of http://bmcr.brynmawr.edu/1998/98.1.02.html is showing an error:
(There are more inconsistencies, which I forgot...) |
This comment has been minimized.
This comment has been minimized.
Sorry, that was just an example, and not a real one. My bad. However, a bunch of the URLs in the 1998 listing at http://bmcr.brynmawr.edu/1998/ are not working. I'll see if I can find out something. |
This comment has been minimized.
This comment has been minimized.
There is another, officially linked listing of the 1998 reviews: http://bmcr.brynmawr.edu/1998/indexb.html |
This comment has been minimized.
This comment has been minimized.
Let's see what they say. |
adam3smith
reviewed
Aug 23, 2016
return "multiple"; | ||
} else if (url.match(/[\d\-]+\.html$/)) { | ||
} else if (url.match(/[\d\-]+\.html$/) && ZU.xpathText(doc, '//h3/i')) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@zuphilip -- not sure I follow the last bits of the discussion. Is this ready to merge or should we wait to hear back from the editors? |
This comment has been minimized.
This comment has been minimized.
Please have a look at the updated version. The translator is ready to merge and works good for 1999ff and even in most cases also before. We don't have to wait to hear from the editors whether they correct some errors or non-standard design (also I appreciate any effort on that). |
adam3smith
merged commit 1f0634a
into
zotero:master
Aug 23, 2016
This comment has been minimized.
This comment has been minimized.
Thanks! |
adam3smith
referenced this pull request
Aug 23, 2016
Closed
Add journal title and abbreviation. #1045
zuphilip
deleted the
zuphilip:bryn-mawr
branch
Aug 23, 2016
This comment has been minimized.
This comment has been minimized.
Thanks to @Jmuccigr for starting with this and having patience to wait some time until we now have it merged. Thank you! |
zuphilip commentedAug 22, 2016
This is the continuation of #1045 :
detectWeb
doWeb
ZU.xpath
andZU.xpathText
instead ofdoc.evaluate
reviewAuthors
url
directly for extractingdate
extra
I tested it quite extensively and it seems to be stable now.