Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreated a translator for Antikvarium.hu #1411
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks! In general this looks great, but some higher level concerns:
Thanks again! |
This comment has been minimized.
This comment has been minimized.
We're now pretty comfortable allowing ES6 for new development. We don't need to go out of our way to break existing translators, particularly core ones, but Safari 10, which supports most ES6 features (certainly |
This comment has been minimized.
This comment has been minimized.
Additionally, please also add some test cases. |
This comment has been minimized.
This comment has been minimized.
OK, thanks Dan. @petervelosy ignore the part about ES6 then, but the other issues do still apply, as does the request for test cases per @zuphilip |
petervelosy
and others
added some commits
Sep 16, 2017
This comment has been minimized.
This comment has been minimized.
Please check if this all makes sense. We'd want the extra information in a note, not the Extra field, so I moved that. Apart from that I just fixed things and added multiples & tests (please do test your code before comitting, though; what you had didn't run at all) |
This comment has been minimized.
This comment has been minimized.
AronSeidl
commented
Nov 10, 2017
Thank you for all these changes and the clarification, it all makes sense now. Is there anything else I need to do, or is this translator ready for merging? |
This comment has been minimized.
This comment has been minimized.
P.s. The last comment was by me, but a colleague was logged in with his GitHub account on this PC. |
zuphilip
merged commit 250985d
into
zotero:master
Nov 11, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
This PR is now merged and the new translator will get deployed now Thank you very much @petervelosy! |
petervelosy commentedSep 14, 2017
No description provided.