Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate GitHub API comment #1621
Conversation
katrinleinweber
and others
added some commits
Apr 13, 2018
zuphilip
force-pushed the
katrinleinweber:patch-3
branch
from
196ea02
to
beea162
Apr 14, 2018
This comment has been minimized.
This comment has been minimized.
I updated the translator a little bit more and updated also the test cases. Please have a look. I don't know whether the Github API changed but these comments seem for me of little value anyways. I tried to replace them with something more meaningful. Why do you think we should change how we save the owner information? E.g. zotero is the company but Dan would be a programmer seems still fine for me. |
This comment has been minimized.
This comment has been minimized.
Thanks for the update :-) To elaborate on my "PS": Maybe I'm seeing a bug. Does importing an organisational repo result in any Dan for example, only appears as From #1296 I understood that |
This comment has been minimized.
This comment has been minimized.
No, the organization will be saved in the company field. We also tried to look at the contributors, which need another API call, e.g. https://api.github.com/repos/zotero/zotero/contributors, but this list was too much to be meaningful in general. For doing better we might need more information to rely on, e.g. a CODEMETA file. |
This comment has been minimized.
This comment has been minimized.
Hm. I'd argue that at least adding the 0-th contributor (with most contributions) as |
zuphilip
merged commit e6d0a61
into
zotero:master
Apr 16, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
@katrinleinweber Thank you! I try to look at the #1587 soon and then we possibly can revisit GitHub translator afterwards again. |
This comment has been minimized.
This comment has been minimized.
Thank you :-) |
katrinleinweber commentedApr 13, 2018
•
edited
stats
is nowhere to be found on https://api.github.com/repos/zotero/zotero, nor any users' forks like https://api.github.com/repos/zuphilip/zotero. I think GH updated the API URL as in the diff. If that's the one meant by the comment, please consider merging this.PS: If the above is true, I'm guessing that "organization in GitHub cannot itself provide contributions" from #1296 is now outdated, and the translator could be updated in that way. If yes, shall I open an issue, or is that change trivial and can be appended here?