Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator for theses.fr #1645

Merged
merged 3 commits into from Sep 10, 2018

Conversation

@TesteFixe
Copy link
Contributor

commented May 4, 2018

A new translator for http://theses.fr, institutional repository of french doctoral thesis

Add theses.fr
A new translator for http://theses.fr, institutional repository of french doctoral thesis

@TesteFixe TesteFixe changed the title Add a translator for theses.fr Translator for theses.fr May 15, 2018

@adam3smith
Copy link
Collaborator

left a comment

Sorry for the delay. I have a couple of small questions & change requests, but my biggest concern is that the site isn't working for me at all (all thesis links like http://www.theses.fr/s197772 just link back to the search screen)-- is it broken or is access gated?

ThesesFR.js Outdated
],
"tags": [
{
"tag": "RGD Chitosan Nanoparticles Cell adhesion Wound healing"

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 12, 2018

Collaborator

These don't look right. These are multiple tags. Maybe split on capital letter?

ThesesFR.js Outdated
translator.setHandler('itemDone', function(obj, item) {
//add type
//converting internal info:eu-repo/semantics/doctoralThesis notation to "Ph.D. Thesis" only for collections and items
if (item.url.indexOf("/handle/") > -1) {

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 12, 2018

Collaborator

use includes("string")

ThesesFR.js Outdated

function detectWeb(doc, url) {

if (url.indexOf("?q=") != -1) {

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 12, 2018

Collaborator

use includes() for testing strings

ThesesFR.js Outdated

if (url.indexOf("?q=") != -1) {
return "multiple";
} else if (url.indexOf("?q=") == -1) {

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 12, 2018

Collaborator

ditto

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 12, 2018

Collaborator

also, take advantage of checkSearchResults below and use that here to avoid false positives.

This comment has been minimized.

Copy link
@TesteFixe

TesteFixe Aug 16, 2018

Author Contributor

Hi,
Theses.fr is Ok : link works : http://www.theses.fr/s197772
Thanks a lot for your reviewing : i'll make the changes asap!

This comment has been minimized.

Copy link
@TesteFixe

TesteFixe Aug 24, 2018

Author Contributor

Many thanks for your review!

@adam3smith adam3smith added the waiting label Aug 12, 2018

Update ThesesFR.js
Hi
We made the update you request
Thanks!!
@symac

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Hi @adam3smith, do you still have this issue ? Right now if I follow the link you gave, I can see a detailed record :
capture du 2018-08-23 17-11-32

@adam3smith adam3smith removed the waiting label Aug 24, 2018

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Aug 24, 2018

@symac working now -- I believe the issue wasn't just for me

@TesteFixe

This comment has been minimized.

Copy link
Contributor

commented on eafea4b Sep 10, 2018

Thanks a lot!!

@adam3smith adam3smith merged commit 35475a9 into zotero:master Sep 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.