Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Engineering Village #1753

Merged
merged 3 commits into from Oct 8, 2018

Conversation

@adam3smith
Copy link
Collaborator

commented Sep 27, 2018

after some site changes. Thankfully small changes -- the post request happens in a window,that only pops up briefly & then closes. This wouldn't have been fun to re-create...

adam3smith and others added some commits Sep 27, 2018

Update Engineering Village
after some site changes.
@zuphilip
Copy link
Collaborator

left a comment

Please have a look at my changes and suggestions for another modification. If we can change that as well, then you should also add the AGPL license as it looks that almost everything changed here from the beginning. AFAIK I have not access to this database.

if (!title) continue;

if (checkOnly) return true;
found = true;

items[docid] = {
title: ZU.trimInternal(title.textContent),
checked: checkbox.checked
}
checked: checkbox.checked // TODO is this still needed?

This comment has been minimized.

Copy link
@zuphilip

zuphilip Oct 7, 2018

Collaborator

It looks for me that this is not anymore needed and therefore we can also switch to our default template for the function getSearchResults. Can you try that out @adam3smith ?

function getSearchResults(doc, checkOnly) {
var rows = doc.getElementsByClassName('result'),
var rows = doc.querySelectorAll('div[class*=result-row]'),

This comment has been minimized.

Copy link
@zuphilip

zuphilip Oct 7, 2018

Collaborator

FYI A comma (not semi-colon) because several variables are defined here.

@adam3smith adam3smith merged commit 686ee8c into zotero:master Oct 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adam3smith adam3smith deleted the adam3smith:EV-update branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.