Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename imageLinks to imageGraph; resolves #419 #421

Merged
merged 2 commits into from Feb 10, 2020
Merged

Rename imageLinks to imageGraph; resolves #419 #421

merged 2 commits into from Feb 10, 2020

Conversation

@ruebot
Copy link
Member

ruebot commented Feb 10, 2020

GitHub issue(s): #419

What does this Pull Request do?

Rename imageLinks to imageGraph

How should this be tested?

  • TravisCI should take care of it.

Additional Notes:

Documentation PR here: archivesunleashed/aut-docs#46

@ruebot ruebot requested a review from ianmilligan1 Feb 10, 2020
@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Feb 10, 2020

@lintool want me to change this to imagegraph? Or change webgraph to webGraph? The latter looks funky, and I can live with imagegraph.

@lintool

This comment has been minimized.

Copy link
Member

lintool commented Feb 10, 2020

Updates might have crossed: I commented on this question in #420 (comment)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          41       41           
  Lines        1570     1570           
  Branches      292      292           
=======================================
  Hits         1224     1224           
  Misses        218      218           
  Partials      128      128
@ianmilligan1 ianmilligan1 merged commit 87c9734 into master Feb 10, 2020
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 77.96%)
Details
codecov/project 77.96% (+0%) compared to ae2f097
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-419 branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.