Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: Rclean: A Tool for Writing Cleaner, More Transparent Code #1312
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @cboettig, it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@benmarwick asked in the Pre-review issue whether submitting to Ropensci had been considered. Comments, @MKLau? |
This comment has been minimized.
This comment has been minimized.
@labarba @benmarwick Per "Has there been any discussion about whether this pkg might be suitable for @ropensci onboarding? Perhaps @noamross or @maelle could advise if this pkg is suitable? It it passes that, then it's auto-submitted here, if I understand correctly." The on-boarding process sounds very useful. Also, I am familiar with Noam Ross's work and would think that he would be suitable to review. I'm not quite sure that I fully understand the suggestion though. Would we do a submission to ROpenSci in addition to (e.g. for on-boarding) or in-lieu of submitting to JOSS? |
This comment has been minimized.
This comment has been minimized.
We have an agreement with ROpenSci where if your package goes through their review, it gets fast-tracked to a publication in JOSS with minor editorial checks. |
This comment has been minimized.
This comment has been minimized.
OK, if we go that route, what are the next steps given that we've already started the review here? |
This comment has been minimized.
This comment has been minimized.
We can just pause the review, and wait until you ping us back! |
This comment has been minimized.
This comment has been minimized.
Ah, ok. That seems good. I'll look at their review process and let your know. Thanks! |
This comment has been minimized.
This comment has been minimized.
@cboettig, @benmarwick — Thank you for agreeing to review this JOSS submission. The review is now paused, while the author investigates going the ROpenSci route. Stay tuned! |
This comment has been minimized.
This comment has been minimized.
@MKLau |
This comment has been minimized.
This comment has been minimized.
@labarba Yes, I'm almost done with a couple of pre-submission edits based on the ROpenSci guidelines. Shooting to submit before the end of this month. Thanks! |
This comment has been minimized.
This comment has been minimized.
@MKLau before submission to rOpenSci you can open a pre-submission inquiry so that the editors might assess whether your package is in scope. Thank you! |
This comment has been minimized.
This comment has been minimized.
@maelle will do, thanks! |
This comment has been minimized.
This comment has been minimized.
Submitted a presub inquiry see #300. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Hi Daniel, sorry for the slow reply I've been traveling and just saw this post. Not much happened last month, but shouldn't be more than a week to get things finished for submission. There are a few more functions that need some tests and the vignette needs to be added: https://github.com/ProvTools/Rclean/projects/4. |
This comment has been minimized.
This comment has been minimized.
Hi @danielskatz @labarba @benmarwick, the package review should be good to start. I made an inquiry over in pre-submission thread ropensci/software-review#300 to see what the best way would be to proceed. One of you might have a thought as well. Should I just re-open the closed pre-submission thread and re-label it? Or, should I start a new issue? Thanks! |
This comment has been minimized.
This comment has been minimized.
I don't know how you submit to rOpenSci, but that's what you need to do next. Once your software is reviewed there, it will be fast-tracked in JOSS. |
This comment has been minimized.
This comment has been minimized.
@labarba @MKLau To submit to rOpenSci, simply open an issue in https://github.com/ropensci/software-review/ as described in the README there. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1312 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
This comment has been minimized.
This comment has been minimized.
@MKLau - please fix the problems in the .md and/or .bib files, perhaps updating them based on recent changes made for the rOpenSci process |
This comment has been minimized.
This comment has been minimized.
@danielskatz Ah ok, I’ll take a look. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@danielskatz , looks like it should be good to go now. |
This comment has been minimized.
This comment has been minimized.
thanks - I'll proofread this soon. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon assign @danielskatz as editor |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
No archive DOI set. Exiting... |
This comment has been minimized.
This comment has been minimized.
I can then move forward with accepting the submission. |
This comment has been minimized.
This comment has been minimized.
Also, please merge the changes in ropensci/Rclean#202 |
This comment has been minimized.
This comment has been minimized.
Thanks @danielskatz for the edits. I've reviewed and accepted your pull request and tagged as v1.1.8. Here's the DOI and link to Zenodo. 10.5281/zenodo.3665732 |
This comment has been minimized.
This comment has been minimized.
@whedon set v1.1.8 as version |
This comment has been minimized.
This comment has been minimized.
OK. v1.1.8 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3665732 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3665732 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1305, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
There are also some changes needed in the bib file - please merge ropensci/Rclean#203 |
This comment has been minimized.
This comment has been minimized.
|
whedon commentedMar 10, 2019
•
edited
Submitting author: @MKLau (Matthew Lau)
Repository: https://github.com/ropensci/Rclean
Version: v1.1.8
Editor: @danielskatz
Reviewer: @danielskatz
Archive: 10.5281/zenodo.3665732
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@danielskatz, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @danielskatz know.
Review checklist for @danielskatz
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?