Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update springer-basic-author-date.csl #4562

Merged
merged 2 commits into from Feb 15, 2020

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Feb 13, 2020

via #4389
Note, the exact formatting that is request is not possible (insert version in-between publisher and publisher-place with dots), to the best of my knowledge.
I placed the Version between container-title and the publisher macro.

via #4389
Note, the exact formatting that is request is not possible (insert version in-between publisher and publisher-place with dots), to the best of my knowledge.
I placed the Version between container-title and the publisher macro.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 13, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 13, 2020

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 13, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

springer-basic-author-date.csl (modified style; unchanged output for sample items)
(Hancké et al. 2007; 2012)
(Mares 2001; Fenner et al. 2019)

(2012) CSL search by example. In: Citation Style Editor. http://editor.citationstyles.org/searchByExample/. Accessed 15 Dec 2012
Fenner M, Crosas M, Grethe JS, et al (2019) A data citation roadmap for scholarly data repositories. Sci Data 6:28. https://doi.org/10.1038/s41597-019-0031-8
Hancké B, Rhodes M, Thatcher M (eds) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York
Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA, Soskice D (eds) Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, pp 184–213
@bwiernik

This comment has been minimized.

Copy link
Contributor

bwiernik commented Feb 15, 2020

No, it should definitely be possible to do that format (though its dumb; version more correctly belongs next to the title). In practice, it seems to be placed after the title: https://link.springer.com/article/10.1007/s00027-020-0701-9

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Feb 15, 2020

It's possible, but cumbersome. You'd do (in pseudo-code)
if version
delimit elements by ". "
else
delimit elements by ", "

But anyway -- I can't find any basis for the format suggested in the other thread and I completely agree with bwiernik (and the example he posts) that the version number belongs with the title, so merging this as is.

@adam3smith adam3smith merged commit bf1ddae into citation-style-language:master Feb 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.