Skip to content

/ rio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require arrow even if tests will not be run #261

Merged
merged 1 commit into from Mar 1, 2020
Merged

Don't require arrow even if tests will not be run #261

merged 1 commit into from Mar 1, 2020
+6 −13

Conversation

@billdenney
Copy link
Contributor

billdenney commented Jan 27, 2020

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

The parquet tests failed because the required arrow to be installed outside of the test if arrow is installed. The test for arrow being available is now inside the test that it is installed. (I don't use arrow yet, so I don't know if skip_if_not(arrow::arrow_available()) is redundant with the previous line.
@billdenney
Don't require arrow even if tests will not be run
Loading status checks…
f4be83c
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Jan 27, 2020 •
edited

Codecov Report

Merging #261 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   86.75%   86.02%   -0.73%     
==========================================
  Files          20       20              
  Lines         959      959              
==========================================
- Hits          832      825       -7     
- Misses        127      134       +7
Impacted Files Coverage Δ
R/remote_to_local.R 44.73% <0%> (-18.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74db9...f4be83c. Read the comment docs.
@leeper leeper added the bug label Mar 1, 2020
@leeper leeper merged commit 47bb5f6 into leeper:master Mar 1, 2020
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing ba74db9...f4be83c
Details
codecov/project Absolute coverage decreased by -0.73, only covered lines were removed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner

leeper commented Mar 1, 2020

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@billdenney @codecov-io @leeper
You can’t perform that action at this time.