Skip to content

/rio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'.import.rio_rdata()' and 'import.rio_rds()' no longer passing '...' … #229

Merged
merged 1 commit into from Oct 2, 2019
+21 −2

Conversation

@bokov
Copy link
Contributor

commented Sep 23, 2019

…to 'load()' nor to 'readRDS()' because those underlying functions cannot accept '...' arguments. Instead, the length of '...' is checked and if > 0 a warning is issued. With corresponding tests. As proposed in #223

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
    Issue #223
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
    Awaiting guidance.
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
    No changes
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

No failures attributable to this PR.
@bokov
'.import.rio_rdata()' and 'import.rio_rds()' no longer passing '...' …
Loading status checks…
70fbe9d 
…to 'load()' nor to 'readRDS()' because those underlying functions cannot accept '...' arguments. Instead, the length of '...' is checked and if > 0 a warning is issued. With corresponding tests. As proposed in #223
@bokov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 23, 2019

SInce the rds format has the same issue as rdata and they're thematically related I included that too, and did tests for it as well.
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Sep 23, 2019 •
edited

Codecov Report

Merging #229 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   82.43%   82.51%   +0.08%     
==========================================
  Files          18       18              
  Lines         871      875       +4     
==========================================
+ Hits          718      722       +4     
  Misses        153      153
Impacted Files Coverage Δ
R/import_methods.R 80.41% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d26ca...70fbe9d. Read the comment docs.
@bokov bokov referenced this pull request Sep 30, 2019
Open
1 of 3 tasks complete
@leeper leeper merged commit 9e1a91f into leeper:master Oct 2, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 82.43%)
Details
codecov/project 82.51% (+0.08%) compared to 70d26ca
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Oct 2, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bokov @codecov-io @leeper
You can’t perform that action at this time.