Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ISBN to Internet Archive metadata #2137
Conversation
Books on IA have ISBNs but this info isn't being scraped. Add support to add this info. Add book to tests with ISBN (Example URL) https://archive.org/details/darktowersdeutsc0000enri/mode/2up
This comment has been minimized.
This comment has been minimized.
This work but for some reason the 10 digit isbns aren't making it into the final citation... do those get cleaned out or something upstream? |
This comment has been minimized.
This comment has been minimized.
which citation output (how generated) are you referring to? |
This comment has been minimized.
This comment has been minimized.
The test case I added, https://archive.org/details/darktowersdeutsc0000enri/mode/2up When I do ZU.debug(newItem.ISBN) the field has 4 isbns, but when I use the translator file and curl it the isbn 10s are missing. I'm not too bothered by that if you aren't but I was wondering if that was a symptom of something going wrong!
|
This comment has been minimized.
This comment has been minimized.
PS I've linted a little, do you prefer it to go as additional commits in this thread, or as a separate PR? |
This comment has been minimized.
This comment has been minimized.
linting in the same PR, different (non-squashed, obv) commit, please. Thanks! |
mvolz commentedMar 6, 2020
Books on IA have ISBNs but this info isn't being
scraped. Add support to add this info.
Add book to tests with ISBN (Example URL)
https://archive.org/details/darktowersdeutsc0000enri/mode/2up