Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create quaternaire #4602

Open
wants to merge 8 commits into
base: master
from
Open

Conversation

@flosigime
Copy link

flosigime commented Mar 6, 2020

Hello,

I propose a new csl style for the french journal of Quaternary studies.

Regards

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2020

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/quaternaire"]

(compared using ==)

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2020

😟 There are some issues with your submission.

2 tests failed

quaternaire: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "14:19: FATAL: Opening and ending tag mismatch: Contributor line 11 and contributor"]].empty?` to return true, got false

quaternaire: must be parsable as a CSL style

not allowed to add #<CSL::Info::Contributor children=[2]> to #<struct CSL::Info::Children title=#<CSL::Info::Title "Quaternaire">, :"title-short"=nil, id=#<CSL::Info::Id "http://www.zotero.org/styles/quaternaire">, issn=nil, eissn=nil, issnl=nil, link=[#<CSL::Info::Link href="http://www.zotero.org/styles/quaternaire" rel="self" children=[0]>], author=#<CSL::Info::Author children=[2]>, contributor=nil, translator=nil, category=[], published=nil, summary=nil, updated=nil, rights=nil, :"link-dependent-style"=nil>

Please check the test report for details.

<name>Florent Mercey</name>
<email>florent.mercey@inrap.fr</email>
</author>
<Contributor>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 6, 2020

Member

lowercase the C

<email>f.capron37@gmail.com</email>
</contributor>
<category citation-format="author-date"/>
<category field="Geology"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 6, 2020

Member

and lowercase geology

This comment has been minimized.

Copy link
@flosigime

flosigime Mar 6, 2020

Author

thanks !

lowercase C in Contributor an G in Geology (line 11 an 16)
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

quaternaire.csl (new)
(Hancké, Rhodes & Thatcher, 2007 ; 2012)
(Mares, 2001 ; Fenner et al., 2019)

2012 - CSL search by example. Citation Style Editor 2012, mis en ligne le 2012, consulté le 15 décembre 2012. URL : http://editor.citationstyles.org/searchByExample/

FENNER M., CROSAS M., GRETHE J.S., KENNEDY D., HERMJAKOB H., ROCCA-SERRA P., DURAND G., BERJON R., KARCHER S., MARTONE M. & CLARK T., 2019 - A data citation roadmap for scholarly data repositories. Scientific Data, 6 (1), 28.

HANCKÉ B., RHODES M. & THATCHER M. (Dir.) - , 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 6, 2020

strange behaviour with the "(Dir) -". No comma after that in my zotero locally...

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 6, 2020

so strange. It doesn't happens on https://editor.citationstyles.org/codeEditor/

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Mar 8, 2020

Thanks! Did you base this on an existing CSL style? If so, we'd like to know which one, so we can add a "template" link (see https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link)

strange behaviour with the "(Dir) -". No comma after that in my zotero locally...

Can you elaborate a bit on the issue you're seeing? Can you e.g. give the full citation, as rendered by Zotero and by https://editor.citationstyles.org/codeEditor/?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 8, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

quaternaire.csl (new)
(Hancké, Rhodes & Thatcher, 2007 ; 2012)
(Mares, 2001 ; Fenner et al., 2019)

2012 - CSL search by example. Citation Style Editor 2012, mis en ligne le 2012, consulté le 15 décembre 2012. URL : http://editor.citationstyles.org/searchByExample/

FENNER M., CROSAS M., GRETHE J.S., KENNEDY D., HERMJAKOB H., ROCCA-SERRA P., DURAND G., BERJON R., KARCHER S., MARTONE M. & CLARK T., 2019 - A data citation roadmap for scholarly data repositories. Scientific Data, 6 (1), 28.

HANCKÉ B., RHODES M. & THATCHER M. (Dir.) - , 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 8, 2020

😟 There are some issues with your submission.

1 test failed

quaternaire: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[24, "24:0: ERROR: Did not expect element macro there"], [24, "24:0: ERROR: Element style has extra content: macro"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

Please check the test report for details.

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 8, 2020

Thanks! Did you base this on an existing CSL style? If so, we'd like to know which one, so we can add a "template" link (see https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link)

Yes. The base is the revue-archeologique-du-centre-de-la-france style

strange behaviour with the "(Dir) -". No comma after that in my zotero locally...

Can you elaborate a bit on the issue you're seeing? Can you e.g. give the full citation, as rendered by Zotero and by https://editor.citationstyles.org/codeEditor/?

looking for it, but things have changed...

<substitute>
<text macro="editor" font-weight="bold" suffix=" (Dir.) - "/>
<namves variable="editor"/>

This comment has been minimized.

Copy link
@flosigime

flosigime Mar 8, 2020

Author

and i absolutely need the suffix (Dir.) - for the editors. Deleting this, and i have (Ed.) which is impossible...

This comment has been minimized.

Copy link
@flosigime

flosigime Mar 8, 2020

Author

error in namves

Copy link
Author

flosigime left a comment

Yes ! Thanks for this. Many details...

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 8, 2020

strange behaviour with the "(Dir) -". No comma after that in my zotero locally...

Can you elaborate a bit on the issue you're seeing? Can you e.g. give the full citation, as rendered by Zotero and by https://editor.citationstyles.org/codeEditor/?

with you code, rmzelle, on code editor :

HANCKÉ B., RHODES M. & THATCHER M. (Dir.) - 2007 - Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York, NY.

here, on github

HANCKÉ B., RHODES M. & THATCHER M. (Dir.) - , 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

but i'm a bit lost between the differents changes, yours rmzelle, and those made by sebastian...

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 9, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

quaternaire.csl (new)
(Hancké, Rhodes & Thatcher, 2007 ; 2012)
(Mares, 2001 ; Fenner et al., 2019)

2012 - CSL search by example. Citation Style Editor 2012, mis en ligne le 2012, consulté le 15 décembre 2012. URL : http://editor.citationstyles.org/searchByExample/

FENNER M., CROSAS M., GRETHE J.S., KENNEDY D., HERMJAKOB H., ROCCA-SERRA P., DURAND G., BERJON R., KARCHER S., MARTONE M. & CLARK T., 2019 - A data citation roadmap for scholarly data repositories. Scientific Data, 6 (1), 28.

HANCKÉ B., RHODES M. & THATCHER M. (éd.), 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (éd.) (dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 9, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

quaternaire.csl (new)
(Hancké, Rhodes & Thatcher, 2007 ; 2012)
(Mares, 2001 ; Fenner et al., 2019)

2012 - CSL search by example. Citation Style Editor 2012, mis en ligne le 2012, consulté le 15 décembre 2012. URL : http://editor.citationstyles.org/searchByExample/

FENNER M., CROSAS M., GRETHE J.S., KENNEDY D., HERMJAKOB H., ROCCA-SERRA P., DURAND G., BERJON R., KARCHER S., MARTONE M. & CLARK T., 2019 - A data citation roadmap for scholarly data repositories. Scientific Data, 6 (1), 28.

HANCKÉ B., RHODES M. & THATCHER M. (dir.), 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 9, 2020

Have a look at the sample citations now -- I think these are correct and better in line with both the style guide and examples printed in the journal than what you had before.
The extra comma in the sample references earlier was due to the fact that the software used to create citations here is slightly different from that in the the editor and Zotero, so there are sometimes small differences.

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 9, 2020

Have a look at the sample citations now -- I think these are correct and better in line with both the style guide and examples printed in the journal than what you had before.

Yes thanks a lot ! It seems really nice. With an uppercase to dir (Dir.), it will be perfect.
(Sorry, i didn't find how to create a commit...Github is weird to me....)

The extra comma in the sample references earlier was due to the fact that the software used to create citations here is slightly different from that in the the editor and Zotero, so there are sometimes small differences.

Ok for the sample. I thought it could be something like this. It worked on zotero and everywhere else. I was not really worried...

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 9, 2020

yes i Did find how to create a commit :-D

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 9, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

quaternaire.csl (new)
(Hancké, Rhodes & Thatcher, 2007 ; 2012)
(Mares, 2001 ; Fenner et al., 2019)

2012 - CSL search by example. Citation Style Editor 2012, mis en ligne le 2012, consulté le 15 décembre 2012. URL : http://editor.citationstyles.org/searchByExample/

FENNER M., CROSAS M., GRETHE J.S., KENNEDY D., HERMJAKOB H., ROCCA-SERRA P., DURAND G., BERJON R., KARCHER S., MARTONE M. & CLARK T., 2019 - A data citation roadmap for scholarly data repositories. Scientific Data, 6 (1), 28.

HANCKÉ B., RHODES M. & THATCHER M. (Dir.), 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (Dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 9, 2020

Where are you getting the capitalized dir. from? I'm seeing
image
in the instructions for authors and consistently lowercase dir. in the journal

@flosigime

This comment has been minimized.

Copy link
Author

flosigime commented Mar 9, 2020

I did it. in the last commit :

HANCKÉ B., RHODES M. & THATCHER M. (Dir.), 2007 - Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.

MARES I., 2001 - Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall et D. Soskice (Dir.), Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University Press, New York, 184‑213.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 9, 2020

I understand that you changed it in the style code. I'm asking why you did, because that's not what I'm seeing in the journal and its instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.