Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make harvard-university-of-gloucestershire.csl dependent #3551

Merged
merged 3 commits into from Jun 16, 2018

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Jun 15, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 15, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 15, 2018

😟 There are some issues with your submission. Please check the test report for details.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Jun 15, 2018

harvard-stellenbosch-university & harvard-university-of-cape-town have this as a template link. That shouldn't matter, right?

rmzelle added 2 commits Jun 16, 2018
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 16, 2018

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 16, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 7184875 into citation-style-language:master Jun 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jun 16, 2018

Thanks!

harvard-stellenbosch-university & harvard-university-of-cape-town have this as a template link. That shouldn't matter, right?

Well, actually we currently require that all "template" links link to existing CSL independent styles. I certainly helps catch typos, but the drawback is that we get cases like these. I just pointed the "template" links to the parent style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.