Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upThieme dependents #2783
Thieme dependents #2783
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 2, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
I updated the "thieme-e-journals-vancouver.csl" style with the code from the style submitted at #2721. A few things that need checking:
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 2, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 3, 2017
|
This comment has been minimized.
This comment has been minimized.
(I just realized I didn't set up redirects in renamed-styles.json for the independent styles we're deleting that have different names in their dependent form; we could also change the metadata to keep the journal titles and style IDs the same) |
This comment has been minimized.
This comment has been minimized.
I did a quick check and the International Journal of Sports Medicine publishes in English with English abbreviations (i.e. ed instead of Hrsg.) and Röfo uses et al for > authors, as does DMW. If we're in a rush here, I'd leave these independent and check back with @juliarojahn |
This comment has been minimized.
This comment has been minimized.
Sure. I can put them on the skip list for now and update the PR in the styles repo. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, I updated both the "journals" and "styles" PRs to do just that. Should be good to squash and merge. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
This comment has been minimized.
This comment has been minimized.
juliarojahn
commented
Jul 14, 2017
Please include the Journal DMW in the style - it should use the same style, and the colleagues would be very happy to be included! The journals with english citations (International Journal of Sports Medicine, RöFo etc.) I can tackle afterwards. |
This comment has been minimized.
This comment has been minimized.
OK, we'll fix this so it includes DMW and then merge it over the weekend. Sorry for the delay |
This comment has been minimized.
This comment has been minimized.
Hmz, looks like I should have done DMW instead of the European Journal of Ultrasound. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, just made this change. Feel free to merge (and the journals PR mentioned at the top of this PR as well). |
This comment has been minimized.
This comment has been minimized.
great, thanks! |
rmzelle commentedJul 2, 2017
•
edited
Via citation-style-language/journals#39
(replaces #2721)