Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bulletin-of-the-seismological-society-of-america.csl #3647

Merged
merged 3 commits into from Aug 14, 2018

Conversation

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 14, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 14, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 14, 2018

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

One nit, one question. Thanks!

</if>
</choose>
</macro>
<macro name="mapinfo">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 14, 2018

Member

Is this from the template style? Can we do better here? I really don't like using note in styles.

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Aug 14, 2018

Author Contributor

Sure. Guidelines not stating anything, but I guess this could be useful for seismologists.

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 14, 2018

Member

what info is in there, though? We do, e.g., have "scale" for maps in Zotero&CSL?

</macro>
<macro name="accessed">
<choose>
<if type="webpage post-weblog">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 14, 2018

Member

needs match="any" (otherwise defaults to match="all" even though Zotero/citeproc-js may not implement that correctly.

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Aug 14, 2018

Author Contributor

I wonder how that would've happened. I did this in the visual editor like always (click on plus and add post-weblog). thanks for spotting.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 14, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 1fa453d into citation-style-language:master Aug 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Aug 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.