Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate acta-ichthyologica-et-piscatoria.csl #4154
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 21, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 21, 2019
Below are some sample citations generated based on your proposed changes: acta-ichthyologica-et-piscatoria.csl (new)(Hancké et al. 2007; 2012) |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 21, 2019
Below are some sample citations generated based on your proposed changes: acta-ichthyologica-et-piscatoria.csl (new)(Hancké et al. 2007; 2012) |
<link href="https://aiep.pl/main/instr.php" rel="documentation"/> | ||
<author> | ||
<name>Sebastian Karcher</name> | ||
<name>Patrick O'Brien, PhD</name> | ||
<email>obrienpat86@gmail.com</email> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 21, 2019
Member
@adam3smith, @POBrien333, I assume Patrick just forgot to update the name here.
Yes, he did. Thanks for spotting and fixing :) |
<text macro="author" font-weight="bold"/> | ||
<text macro="year"/> | ||
<text macro="title"/> | ||
<choose> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 23, 2019
Member
Just an FYI if you're looking at the previews -- citeproc-ruby doesn't apply group delimiters within choose
elements contained in the group. This is fine with other citeprocs and I think should be changed in citeproc-ruby (which is doing this technically correctly according to the specs) and it's definitely fine in the styles, so just mentioning this so you don't worry about it.
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 24, 2019
Member
This is fine with other citeprocs and I think should be changed in citeproc-ruby (which is doing this technically correctly according to the specs) and it's definitely fine in the styles, so just mentioning this so you don't worry about it.
My thinking about this has always been that style authors should be able to add <choose/>
elements (e.g. to cover exceptions) without affecting the original functioning of the style, so yes, we should clarify this in the spec if needed and get citeproc-ruby to push the delimiter down into the <choose/>
contents.
1398117
into
citation-style-language:master
This comment has been minimized.
This comment has been minimized.
Thanks! |
POBrien333 commentedJun 21, 2019
•
edited by rmzelle
via https://forums.zotero.org/discussion/76794/style-request-acta-ichthyologica-et-piscatoria