Skip to content

/ translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Metadata: Use `innerText` instead of `textContent` #2122

Open
wants to merge 1 commit into
base: master
from
Open

Embedded Metadata: Use `innerText` instead of `textContent` #2122

wants to merge 1 commit into from
+5 −5

Conversation

@dstillman
Copy link
Member

dstillman commented Feb 16, 2020

Closes #2117 (when paired with zotero/translation-server@f0cff95)
@dstillman
Embedded Metadata: Use `innerText` instead of `textContent`
Loading status checks…
8a2da87 
Closes #2117
@dstillman dstillman force-pushed the dstillman:em-innerText branch from fa551d7 to 8a2da87 Feb 16, 2020
@dstillman dstillman mentioned this pull request Feb 17, 2020
Open
@mvolz

This comment has been minimized.

Sign in to view
Copy link
Contributor

mvolz commented Mar 12, 2020

Does this just need to be linted before merge?
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Mar 12, 2020

I think we're not linting on translators with multiple open PRs to avoid the hassle of merge conflicts, so good on that end. It'd be good to run a couple of tests on translators that call on EM to make sure there are no changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Embedded metadata translator puts CSS/javascript in author field (and emails too)
3 participants
@dstillman @mvolz @adam3smith
You can’t perform that action at this time.