Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/ styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AGLC4 #3951

Merged
merged 9 commits into from Apr 16, 2019
Merged

Add AGLC4 #3951

merged 9 commits into from Apr 16, 2019

Conversation

@adam3smith
Copy link
Member

adam3smith commented Feb 24, 2019

No description provided.

adam3smith added 2 commits Feb 24, 2019
@adam3smith
Provide updated AGLC 4 Edition
bbb853e
@adam3smith
AGLC4 - Bibliography
Loading status checks…
12a0968
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 24, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
adam3smith added 2 commits Feb 24, 2019
@adam3smith
Fix AGLC3 ID
Loading status checks…
2d762c1
@adam3smith
Various AGLC4 fixes
Loading status checks…
80ba6a6
@rmzelle
rmzelle reviewed Feb 26, 2019
View changes
australian-guide-to-legal-citation.csl Outdated
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-GB">
<info>
<title>Australian Guide to Legal Citation</title>
<title>Australian Guide to Legal Citation, 4th Edition</title>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Feb 26, 2019

Member

@adam3smith, minor nitpick, but we don't use a comma in any of our edition-versioned styles: https://www.zotero.org/styles?q=%20edition.
@rmzelle
rmzelle reviewed Feb 26, 2019
View changes
australian-guide-to-legal-citation-3rd-edition.csl Outdated
<title-short>AGLC</title-short>
<id>http://www.zotero.org/styles/australian-guide-to-legal-citation-3rd-edition</id>
<link href="http://www.zotero.org/styles/australian-guide-to-legal-citation-3rd-edition" rel="self"/>
<link href="https://forums.zotero.org/discussion/4841/new-australian-legal-citation-style/?Focus=20831#Comment_20831" rel="documentation"/>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Feb 26, 2019

Member

This documentation link doesn't highlight a comment for me. Seems to be the old forums syntax. (@adam3smith, you're currently reusing this old link for the 4th edition)
@rmzelle
rmzelle reviewed Feb 26, 2019
View changes
australian-guide-to-legal-citation-3rd-edition.csl Outdated
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-GB">
<info>
<title>Australian Guide to Legal Citation</title>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Feb 26, 2019

Member

Title should be updated to also say "3rd edition" (without a preceding comma, probably)
@stale

This comment has been minimized.

Sign in to view
Copy link

stale bot commented Mar 28, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.
@stale stale bot added the waiting label Mar 28, 2019
@stale stale bot closed this Apr 11, 2019
@adam3smith adam3smith reopened this Apr 11, 2019
@stale stale bot removed the waiting label Apr 11, 2019
@adam3smith adam3smith marked this pull request as ready for review Apr 11, 2019
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 11, 2019

😃 Your submission passed all our automated tests.
rmzelle added 3 commits Apr 14, 2019
@rmzelle
Update australian-guide-to-legal-citation-3rd-edition.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cf4c63a
@rmzelle
Update australian-guide-to-legal-citation.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eae453f
@rmzelle
Update australian-guide-to-legal-citation.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
262121b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 14, 2019

😃 Your submission passed all our automated tests.
2 similar comments
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 14, 2019

😃 Your submission passed all our automated tests.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 14, 2019

😃 Your submission passed all our automated tests.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Apr 14, 2019

Looks fine to me.
@adam3smith
Add 3rd edition documentation link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcc2134
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 16, 2019

😃 Your submission passed all our automated tests.
@adam3smith
Add sample library to aglc4
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
503284c
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 16, 2019

😃 Your submission passed all our automated tests.
@adam3smith adam3smith merged commit e4dc24d into master Apr 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adam3smith adam3smith deleted the aglc-4 branch Apr 16, 2019
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Apr 18, 2019

Thanks! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmzelle rmzelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adam3smith @csl-bot @rmzelle
You can’t perform that action at this time.